Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to tests #2050

Merged
merged 3 commits into from Jan 31, 2020
Merged

Minor updates to tests #2050

merged 3 commits into from Jan 31, 2020

Conversation

@mastermatt
Copy link
Contributor

mastermatt commented Jan 20, 2020

While working on #2049, there were several housekeeping items that popped up for me, as a first time contributor. I didn't want to clutter the original PR, so I'm opening this separate one with things I had stashed.

  • Update calls to the deprecated Buffer constructor in a couple tests
  • Replace Istanbul with nyc
  • Run the formatter
mastermatt added 3 commits Jan 20, 2020
Using `new Buffer` has been deprecated since Node v6 and emits a runtime
warning on Node v10+. `Buffer.from(string[, encoding])` has been the
preferred method since v5.10.
nyc is the command-line-client for Istanbul now
https://istanbul.js.org/

```
npm WARN deprecated istanbul@0.4.5: This module is no longer maintained, try this instead:
npm WARN deprecated   npm i nyc
npm WARN deprecated Visit https://istanbul.js.org/integrations for other alternatives.
```
@mastermatt mastermatt requested a review from ricardograca Jan 20, 2020
Copy link
Member

ricardograca left a comment

Looks good. Thank you for the contribution.

@ricardograca ricardograca merged commit a626e98 into bookshelf:master Jan 31, 2020
2 checks passed
2 checks passed
LGTM analysis: JavaScript No new or fixed alerts
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ricardograca ricardograca added this to In progress in Version 1.x.x via automation Jan 31, 2020
@ricardograca ricardograca moved this from In progress to Done in Version 1.x.x Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Version 1.x.x
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.