Minor updates to tests#2050
Merged
Merged
Conversation
Using `new Buffer` has been deprecated since Node v6 and emits a runtime warning on Node v10+. `Buffer.from(string[, encoding])` has been the preferred method since v5.10.
nyc is the command-line-client for Istanbul now https://istanbul.js.org/ ``` npm WARN deprecated istanbul@0.4.5: This module is no longer maintained, try this instead: npm WARN deprecated npm i nyc npm WARN deprecated Visit https://istanbul.js.org/integrations for other alternatives. ```
ricardograca
approved these changes
Jan 31, 2020
ricardograca
left a comment
ricardograca
left a comment
Member
There was a problem hiding this comment.
Looks good. Thank you for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #2049, there were several housekeeping items that popped up for me, as a first time contributor. I didn't want to clutter the original PR, so I'm opening this separate one with things I had stashed.
Bufferconstructor in a couple tests