Cherry-picked fix for attributes syncronization issue onto 0.15 branch#2063
Merged
ricardograca merged 3 commits intobookshelf:0.15from Mar 25, 2020
Merged
Conversation
closes bookshelf#2007 - The attributes object can be modified within `triggerThen` through hooks. Sample scenario described here bookshelf#2007 (comment). - Recalculating 'attributesToSave' object in after-triggerThen step solves the syncronization issue because it is still based on model's `attributes` property (the reference is not lost)
Contributor
Author
|
The linting error seems rather strange. It fails on a file that hasn't ever been touched 🤔 |
Member
Could be due to a newer version of the linter or its rules. Do you mind applying the proposed changes anyway? |
Contributor
Author
|
Sure, don't mind putting them in. Will update soon |
Contributor
Author
|
Think everything is ready for this one to go into 0.15 branch @ricardograca :) |
ricardograca
approved these changes
Mar 25, 2020
Member
ricardograca
left a comment
ricardograca
left a comment
There was a problem hiding this comment.
Thanks a lot. I'll prepare both releases later today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduced changes that came with #2062 into 0.15 branch as discussed here.
@ricardograca let me know if there's anything else is needed here 😉