Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

links to mailing list broken #10

Closed
boombatower opened this issue Dec 12, 2020 · 3 comments · Fixed by #17
Closed

links to mailing list broken #10

boombatower opened this issue Dec 12, 2020 · 3 comments · Fixed by #17

Comments

@boombatower
Copy link
Owner

Based on #9 link generation to mailing list threads is broken since the URLs are not generated in a predictable manor nor are the Archived-At headers included in the mailbox download. The best solution would be for upstream to include the headers as setting up a email subscription and downloading all mail to get the headers is more work and maintenance plus missing the period until it is setup.

@tvogel
Copy link

tvogel commented May 31, 2021

The review page still links emails here. So, is this is issue fixed such that the links could be generated correctly again or rather not?

@boombatower
Copy link
Owner Author

Downloading the mailing list archives to read the emails is restored, but the archive lost the information needed to generate a URL to view the mail from the web. So while the email subjects can be displayed after parsing the replies and bodies a link to the mail cannot.

@doenietzomoeilijk
Copy link

Actually, the URL is predictable. It's generated here, and simply consists of the base32-encoded SHA-1 hash of the e-mail message-ID - which, I think, should be in the inbox.

The latest snapshot at this moment is 20210613, and the announcement e-mail lives here. When I download that message, I get an e-mail with Message-ID: <162371163727.3077.18028238154166268965@go-agent-stagingbot-6>. If I run this line in a Python interpreter:

b32encode(sha1("162371163727.3077.18028238154166268965@go-agent-stagingbot-6").digest()).decode('utf-8')

...then sure enough, the answer is u'ECUAOSYLLWKLG5AL3QGMCQ3AXP3FKQYY', which is the dynamic bit in that mailing list URL.

So. I'm a bit rusty in Python, but I could try my hand at making this work in the current code; if somebody who has the actual code checked out and the whole mail thing set up to give it a go, that's fine too, but unless the MSGID changes from the mailing list to the download, it should be possible to predict the mailing list URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants