Forum topics and replies only getting added to Daily Digest emails for one user #21

Closed
nickharambee opened this Issue Jul 18, 2012 · 9 comments

Projects

None yet

3 participants

@nickharambee

I currently have 12 users on my site, signed up to various public groups, and all are signed up to receive daily digests.  For some reason new posts and replies on the forums (for all groups I have tested) are only getting added to the digest for one user.  New updates on the activity stream, new docs, and new tasks are getting added for all users however.  I am not sure if this is a bug, or a quirk on my set up, and I'm pretty sure it was working OK before.  Perhaps it's related to the recent update of this plugin, perhaps not.  I have tried deactivating and activating the plugin again, with no success.

@r-a-y
Collaborator
r-a-y commented Jul 18, 2012

On the Group Email settings page, did you try clicking on the "View queued digest items" link? (Make sure there are some items queued in the digest and that you're logged in as an admin to view them.)

Does the queued digest show items only for one user?

@nickharambee

Yes, I use the ?sum=1 URL a lot to test what's in the digest queue. What I'm seeing is that all BP activity is getting successfully added to the digest for all users, except new topics and replies on forums which are only getting added to the digest for one user.

@boonebgorges
Owner

Thanks for jumping in here @r-a-y - this part of the codebase is your handiwork :) Let me know if I can help with debugging.

@r-a-y
Collaborator
r-a-y commented Jul 18, 2012

Hi Nick, can you test out my changes and report back?

Overwrite what you have in the plugin with this:
https://github.com/r-a-y/buddypress-group-email-subscription/zipball/group-forum-digests

Thanks for reporting, Nick!

@nickharambee

Hi Ray. I just tested with the new version of bp-activity-subscription-functions.php that you linked to in the first version of your last comment and no activity for the forum got added to the digest, not even for the user who was getting activity added before. Are there any further changes in the zip file you are now linking to?

@r-a-y
Collaborator
r-a-y commented Jul 18, 2012

Yes, there was a new change! See:
r-a-y/buddypress-group-email-subscription@d5812ca

If you're comfortable with making that change do so, otherwise, use the same ZIP link again:
https://github.com/r-a-y/buddypress-group-email-subscription/zipball/group-forum-digests

Thanks again for testing!

@nickharambee

Bingo! (as we say on this side of the pond). That's fixed it. I just tested and both topics and replies are getting added to the digest correctly. Thanks Ray.

On a related matter, I noticed that a backslash is getting added before apostrophes in the digest. I have previously added:

add_filter('digest_item_content','stripslashes');

to

bp-activity-subscription-digest.php

As suggested in this support thread on the plugin page:

http://wordpress.org/support/topic/plugin-buddypress-group-email-subscription-add-apply_filter-to-item-content?replies=3

And I thought this had fixed the issue, but maybe that file only handles some activity, and I need to add the same code, or something similar to:

bp-activity-subscription-functions.php

Or maybe the backslashes will get stripped when the digest is sent? Can you advise on this? Could you add this to the next update so that apostrophes are handled correctly?

Thanks.

@r-a-y
Collaborator
r-a-y commented Jul 19, 2012

Hi Nick,

Thanks for confirming the fix works. I've just opened a pull request to Boone, so this should be addressed in the distribution version of the plugin shortly.

Regarding the filter problem, I've opened a new issue about this: #23.

@nickharambee

Thanks @r-a-y for your help, and for posting the new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment