Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Weekly summary items not recording #35

Closed
r-a-y opened this Issue Dec 10, 2012 · 1 comment

Comments

Projects
None yet
2 participants
Collaborator

r-a-y commented Dec 10, 2012

https://wordpress.org/support/topic/weekly-digest-not-sending

Confirmed. Looking into it.

Update - Looks like weekly summary items are only recorded if that item is "important":
https://github.com/boonebgorges/buddypress-group-email-subscription/blob/master/bp-activity-subscription-functions.php#L452
https://github.com/boonebgorges/buddypress-group-email-subscription/blob/master/bp-activity-subscription-functions.php#L527

Important items include wiki entries and calendar events. I think we should widen the scope of this. Pull request forthcoming.

Collaborator

r-a-y commented Dec 10, 2012

@boonebgorges Check out pull request #34 for this fix. Let me know if you have any Qs!

boonebgorges added a commit that referenced this issue Dec 13, 2012

Reworks the way that items are added to the weekly summary digest
Previously, only older group wiki entries and calendar events could be recorded
into the Weekly Summary.

This commit renames ass_default_important_things() to the more aptly-named
ass_default_weekly_summary_activity_types() and extends support for weekly
summaries to:
- 'bbp_topic_create' - bbPress 2 forum topics
- 'activity_update' - activity updates

See #35

boonebgorges added a commit that referenced this issue Dec 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment