Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDboost does not deal correctly with `is.bdfamily` families. #1

Closed
fabian-s opened this issue Sep 26, 2016 · 2 comments
Closed

FDboost does not deal correctly with `is.bdfamily` families. #1

fabian-s opened this issue Sep 26, 2016 · 2 comments
Assignees

Comments

@fabian-s
Copy link

@fabian-s fabian-s commented Sep 26, 2016

These now expect matrix valued responses cbind(#success, #failures) (gamboostLSS>1.5), but FDboost treats matrix valued responses as functions and shit's all fucked up.

Code examples in supplement to Statmod discussion paper, too long & secret to post here.

@fabian-s
Copy link
Author

@fabian-s fabian-s commented May 3, 2017

Still not working with boost-R/mboost@0326a2a --

set.seed(12) 
n <- 100
grid <- seq(0, 1, l = 20)
xfun <- t(replicate(n, dbeta(grid, runif(1, 3, 10), runif(1, 2, 7))))
xscalar <- rnorm(100)
y_success <- rbinom(n, size = 30, p = plogis(xscalar))
data <- list(y = cbind(y_success, y_fail = 30 - y_success), xfun = xfun, xscalar = xscalar)
m <- FDboost(y  ~ bbs(xscalar) + bsignal(xfun, grid),
  timeformula = NULL, family=Binomial(type="glm"),
  data = data, control = boost_control(mstop = 50, nu = 0.05))

yields:

Error in FDboost(y ~ bbs(xscalar) + bsignal(xfun), timeformula = NULL,  : 
  The length of the response and number of observations of xfun do not match.

because the response matrix for the scalar responses is converted to a long vector in
response <- matrix(response, ncol = 1) https://github.com/boost-R/FDboost/blob/master/R/FDboost.R#L566

@sbrockhaus sbrockhaus self-assigned this May 3, 2017
@sbrockhaus
Copy link
Member

@sbrockhaus sbrockhaus commented May 4, 2017

Thanks for the bug report and the MWE. Works now :-)

@sbrockhaus sbrockhaus closed this May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.