Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updefaults for cross-validation for non-cyclical FDboostLSS #14
Comments
|
thank you for the bug report. this was unintended. Now a model object that is fitted by FDboostLSS has as first class 'FDboostLSS' and thus the correct version of cvrisk is called. |
When fitting an FDboostLSS model with
method = "noncyclic"the resulting S3-object has the classesnc_mboostLSS,FDboostLSSandmboostLSSin this order. Thus, the defaults specified inFDboost:::cvrisk.FDboostLSSwon't apply. (See code below.)Two quick ideas would be to A) change the class order, if that's unproblematic, or B), stress that the folds have to be specified manually in the documentation and deprecate
FDboost:::cvrisk.FDboostLSS.