Skip to content

Conversation

@jinwoong16
Copy link
Collaborator

πŸ“• Issue Number

Close #104

πŸ“™ μž‘μ—… λ‚΄μ—­

κ΅¬ν˜„ λ‚΄μš© 및 μž‘μ—… ν–ˆλ˜ λ‚΄μ—­

  • 둜그인 μ„±κ³΅μ‹œ, 화면을 Pop
  • νšŒμ›κ°€μž… μ„±κ³΅μ‹œ, 화면을 popToRoot
  • 둜그인과 νšŒμ›κ°€μž… μ‹€νŒ¨μ‹œ, alertμ°½ λ„μ›Œμ€Œ

  • μ€‘λ³΅λ˜λŠ” μ΄λ©”μΌλ‘œ 인해 νšŒμ›κ°€μž… μ‹€νŒ¨

  • λ¬Έμ œμ—†μœΌλ©΄ νšŒμ›κ°€μž… 성곡, 처음 뷰둜 λŒμ•„κ°

  • 둜그인 μ‹€νŒ¨μ‹œ, alertλ₯Ό, μ„±κ³΅ν•˜λ©΄ viewλ₯Ό pop

πŸ“˜ μž‘μ—… μœ ν˜•

  • μ‹ κ·œ κΈ°λŠ₯ μΆ”κ°€
  • 버그 μˆ˜μ •
  • λ¦¬νŽ™ν† λ§
  • λ¬Έμ„œ μ—…λ°μ΄νŠΈ

πŸ“‹ 체크리슀트

  • Merge ν•˜λŠ” λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€?
  • μ½”λ”©μ»¨λ²€μ…˜μ„ μ€€μˆ˜ν•˜λŠ”κ°€?
  • PRκ³Ό κ΄€λ ¨μ—†λŠ” 변경사항이 μ—†λŠ”κ°€?
  • λ‚΄ μ½”λ“œμ— λŒ€ν•œ 자기 κ²€ν† κ°€ λ˜μ—ˆλŠ”κ°€?
  • 변경사항이 νš¨κ³Όμ μ΄κ±°λ‚˜ λ™μž‘μ΄ μž‘λ™ν•œλ‹€λŠ” 것을 λ³΄μ¦ν•˜λŠ” ν…ŒμŠ€νŠΈλ₯Ό μΆ”κ°€ν•˜μ˜€λŠ”κ°€?
  • μƒˆλ‘œμš΄ ν…ŒμŠ€νŠΈμ™€ 기쑴의 ν…ŒμŠ€νŠΈκ°€ 변경사항에 λŒ€ν•΄ λ§Œμ‘±ν•˜λŠ”κ°€?

πŸ“ PR 특이 사항

PR을 λ³Ό λ•Œ 주의깊게 λ΄μ•Όν•˜κ±°λ‚˜ λ§ν•˜κ³  싢은 점

    func signUp(email: String, password: String, userDto: UserDTO) -> Single<Bool> {
       ...
            self.auth.createUser(withEmail: email, password: password) { authResult, error in
                do {
                    if let error = error { throw error }
                    guard let authResult = authResult else { throw NetworkServiceError.noAuthError }
                    try self.createUser(uuid: authResult.user.uid, userDto: userDto)

                   /** 이뢀뢄 μΆ”κ°€! */
                    self.uid.accept(self.auth.currentUser?.uid)

                    single(.success(true))
                } catch let error {
                    single(.failure(error))
                }
        ....
    }
  • νŒŒμ΄μ–΄λ² μ΄μŠ€λŠ” νšŒμ›κ°€μž… μ„±κ³΅ν•˜λ©΄, λ°”λ‘œ 둜그인 μ²˜λ¦¬λ©λ‹ˆλ‹€!! 이둜 μΈν•΄μ„œ, Data의 FirebaseService의 νšŒμ›κ°€μž… λ‘œμ§μ— λ‹€μŒλΆ€λΆ„μ„ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.



@sprituz
Copy link
Member

sprituz commented Dec 7, 2022

μ•„μ£Ό μ’‹μŠ΅λ‹ˆλ‹€

1 similar comment
@Jeonhui
Copy link
Member

Jeonhui commented Dec 7, 2022

μ•„μ£Ό μ’‹μŠ΅λ‹ˆλ‹€

@jinwoong16 jinwoong16 merged commit d9dd032 into develop Dec 8, 2022
@jinwoong16 jinwoong16 deleted the feature/SignInSignUpAction branch December 8, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SignInSignUp Action

4 participants