Skip to content

Conversation

@INYEKIM
Copy link
Collaborator

@INYEKIM INYEKIM commented Dec 2, 2024

💡 요약 및 이슈

채팅관련 자잘한 오류 해결

📃 작업내용

  1. 최근 채팅 보기가 화면에 노출되면 다음과 같이 레이아웃 에러가 발생하는걸 해결했습니다.
Unable to simultaneously satisfy constraints.
	Probably at least one of the constraints in the following list is one you don't want. 
	Try this: 
		(1) look at each constraint and try to figure out which you don't expect; 
		(2) find the code that added the unwanted constraint or constraints and fix it. 
(
    "<NSLayoutConstraint:0x301216440 UIButton:0x1026c9800.bottom == LiveStreamFeature.ChatInputField:0x102663980.top - 8   (active)>",
    "<NSLayoutConstraint:0x301216ee0 UIButton:0x1026c9800.bottom == LiveStreamFeature.ChatInputField:0x102663980.bottom   (active)>"
)

Will attempt to recover by breaking constraint 
<NSLayoutConstraint:0x301216ee0 UIButton:0x1026c9800.bottom == LiveStreamFeature.ChatInputField:0x102663980.bottom   (active)>

Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKitCore/UIView.h> may also be helpful.
  1. QA때나왔던 어느곳을 눌러도 키보드가 내려갈 수 있도록 작업했습니다.
  2. 스크롤이 완료된 시점에 last를 계산하도록 수정했습니다.

🙋‍♂️ 리뷰노트

없습니다!

✅ PR 체크리스트

  • 이 작업으로 인해 변경이 필요한 문서가 변경되었나요? (e.g. XCConfig, 노션, README)
  • 이 작업을 하고나서 공유해야할 팀원들에게 공유되었나요? (e.g. "API 개발 완료됐어요", "XCConfig 값 추가되었어요")
  • 작업한 코드가 정상적으로 동작하나요?
  • Merge 대상 브랜치가 올바른가요?
  • PR과 관련 없는 작업이 있지는 않나요?

🎸 기타

@INYEKIM INYEKIM self-assigned this Dec 2, 2024
Copy link
Collaborator

@hyunjuntyler hyunjuntyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

Copy link
Member

@Siwon-L Siwon-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

인예님 같이 디버깅을 조금 해야할 것 같습니다ㅠㅠ


extension ChattingListView: UITableViewDelegate {
func scrollViewDidScroll(_ scrollView: UIScrollView) {
func scrollViewDidEndDecelerating(_ scrollView: UIScrollView) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

인예님 scrollViewDidEndDecelerating 호출 시점이 이상합니다ㅠㅠ
버튼이 가장 상단까지 스크롤이 되지 않으면 안올라와요ㅠ

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엇? 한 번 확인해보겠습니다 시원님!

@INYEKIM INYEKIM merged commit 7015739 into develop Dec 3, 2024
2 checks passed
@INYEKIM INYEKIM deleted the hotfix/keyboard branch December 3, 2024 05:41
@Siwon-L Siwon-L mentioned this pull request Dec 3, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants