Skip to content

πŸ“¦ chore: feed-crawler ν…ŒμŠ€νŠΈλ₯Ό μœ„ν•œ Jest μ„€μΉ˜ 및 경둜 μ„€μ • #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2025
Merged

πŸ“¦ chore: feed-crawler ν…ŒμŠ€νŠΈλ₯Ό μœ„ν•œ Jest μ„€μΉ˜ 및 경둜 μ„€μ • #19

merged 2 commits into from
Jan 16, 2025

Conversation

@CodeVac513
Copy link
Collaborator

@CodeVac513 CodeVac513 commented Jan 14, 2025 •
edited
Loading

πŸ”¨ ν…ŒμŠ€ν¬

ν…ŒμŠ€νŠΈ 컀버리지 μΈ‘μ • λ²”μœ„μ— λŒ€ν•œ κ³ λ―Ό

  • κ²°μ • 사항: μ΄ˆκΈ°μ—λŠ” 전체 μ½”λ“œμ— λŒ€ν•œ 컀버리지 츑정을 μ œμ™Έν•˜κΈ°λ‘œ ν–ˆμŠ΅λ‹ˆλ‹€.

νŒλ‹¨ κ·Όκ±°:

  • ν”„λ‘œμ νŠΈμ˜ ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„±μ΄ 초기 λ‹¨κ³„μ΄λ―€λ‘œ, λ¨Όμ € 핡심 κΈ°λŠ₯에 λŒ€ν•œ ν…ŒμŠ€νŠΈ μž‘μ„±μ— μ§‘μ€‘ν•˜λŠ” 것이 효율적이라고 νŒλ‹¨ν–ˆμŠ΅λ‹ˆλ‹€.
  • ν…ŒμŠ€νŠΈ μ„€μ •κ³Ό 방법에 λŒ€ν•œ ν•™μŠ΅μ΄ ν•„μš”ν•œ μƒν™©μ—μ„œ, 전체 컀버리지 μΈ‘μ •μ€λ³΅μž‘μ„±μ„ μΆ”κ°€ν•  수 μžˆλ‹€κ³  μƒκ°ν–ˆμŠ΅λ‹ˆλ‹€.

μ˜ˆμƒ ν…ŒμŠ€ν¬ 정리

  • CI에 ν•΄λ‹Ήν•˜λŠ” 뢀뢄은 ν…ŒμŠ€νŠΈ μ½”λ“œκ°€ μž‘μ„±μ΄ 되면 슀크립트λ₯Ό μΆ”κ°€ν•˜κ² μŠ΅λ‹ˆλ‹€. (ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„± PRμ—μ„œ ν•¨κ»˜ 컀밋)
  • 핡심 κΈ°λŠ₯에 λŒ€ν•œ ν…ŒμŠ€νŠΈκ°€ μ•ˆμ •ν™”λ˜λ©΄, μ μ§„μ μœΌλ‘œ 컀버리지 μΈ‘μ • λ²”μœ„λ₯Ό ν™•λŒ€ν•  μ˜ˆμ •μž…λ‹ˆλ‹€.

πŸ“‹ μž‘μ—… λ‚΄μš©

  • Feed-Crawler에 jest, ts-jest, @type/jest, cross-env μ„€μΉ˜
  • jest-unit.json, jest-e2e.json, jest-integration.json μ„€μ • 및 script μΆ”κ°€

πŸ“· 슀크린 μƒ·

  • 파일이 λ„ˆλ¬΄ κΈΈμ–΄μ„œ μ˜ˆμ‹œ ν•˜λ‚˜λ§Œ λ“€κ³  μ™”μŠ΅λ‹ˆλ‹€.
    μŠ€ν¬λ¦°μƒ· 2025-01-15 001018

@CodeVac513 CodeVac513 added the πŸ”§ Chore μ„ΈνŒ… κ΄€λ ¨ label Jan 14, 2025
@CodeVac513 CodeVac513 self-assigned this Jan 14, 2025
Jo-Minseok
Jo-Minseok approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@Jo-Minseok Jo-Minseok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ„€μΉ˜ λΆ€λΆ„λ§Œ λ”°λ‘œ μ˜¬λ¦¬μ…¨κ΅°μš” κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€!

asn6878
asn6878 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@asn6878 asn6878 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CodeVac513 CodeVac513 merged commit 6c42fb9 into main Jan 16, 2025
1 check passed
@CodeVac513 CodeVac513 deleted the test/feed-crawler-setup-test branch January 16, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asn6878 asn6878 asn6878 approved these changes

@Jo-Minseok Jo-Minseok Jo-Minseok approved these changes

Assignees

@CodeVac513 CodeVac513

Labels

πŸ”§ Chore μ„ΈνŒ… κ΄€λ ¨

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CodeVac513 @asn6878 @Jo-Minseok