Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the root cert used by example to match the fingerprint in the comment #1121

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@arvidn
Copy link
Contributor

commented May 8, 2018

The comment specifies the fingerprint of the certificate to be
‎de 28 f4 a4 ff e5 b9 2f a3 c5 03 d1 a3 49 a7 f9 96 2a 82 12, but the actual certificate is identical to the one above. The certificate with the specified fingerprint can be found here:

https://www.geotrust.com/resources/root_certificates/certificates/GeoTrust_Global_CA.pem

This patch updates the certificate to actually use the one the comment suggests it is.

@vinniefalco

This comment has been minimized.

Copy link
Member

commented May 8, 2018

Not sure how that happened, thanks!

@codecov

This comment has been minimized.

Copy link

commented May 8, 2018

Codecov Report

Merging #1121 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1121   +/-   ##
========================================
  Coverage    95.48%   95.48%           
========================================
  Files          106      106           
  Lines        10686    10686           
========================================
  Hits         10204    10204           
  Misses         482      482

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46e658a...11fc7c0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.