Fix redefinition of function template#1638
Closed
wx257osn2 wants to merge 1 commit intoboostorg:developfrom
wx257osn2:fix-redefinition-of-function-template
Closed
Fix redefinition of function template#1638wx257osn2 wants to merge 1 commit intoboostorg:developfrom wx257osn2:fix-redefinition-of-function-template
wx257osn2 wants to merge 1 commit intoboostorg:developfrom
wx257osn2:fix-redefinition-of-function-template
Conversation
Author
|
Oops, it had been already fixed at 1de60a0 ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In MSVC, I've got compile error like below (sorry, I'm Japanese so the error messages are Japanese):
Well, the messages says that the functions
boost::beast::teardownandboost::beast::teardown_asyncwere redefined despite the functions had already defined.It seems that the
friendfunctions were redefined when thessl_streamwas instantiated more than once with each different type parameters likeboost::beast::ssl_stream<boost::beast::tcp_stream>andboost::beast::ssl_stream<boost::asio::ip::tcp::socket>.This PR fixes this issue.