Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With heterogeneous lookup, `equal_range` can result in a range with length greater than 1. #123

Merged
merged 7 commits into from Jun 22, 2019

Conversation

@JanEisenhauer
Copy link
Contributor

commented Jun 7, 2019

Do we need tests?

@igaztanaga

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

Can you please add a small test case that reproduces the reported error? Thanks

@JanEisenhauer

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

Is it acceptable to have the struct with_lookup_by_first in both flat_set_test.cpp and flat_map_test.cpp?

@igaztanaga

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

Many thanks, it seems that "count()" has the same problem. I'll apply a fix on top of your patch.

@igaztanaga igaztanaga merged commit 3f09061 into boostorg:develop Jun 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.