Make sure std::string constructor is available#33
Merged
igaztanaga merged 1 commit intoboostorg:developfrom Dec 23, 2015
muggenhor:include-string
Merged
Make sure std::string constructor is available#33igaztanaga merged 1 commit intoboostorg:developfrom muggenhor:include-string
igaztanaga merged 1 commit intoboostorg:developfrom
muggenhor:include-string
Conversation
.. because <stdexcept> only needs to have a forward declaration of std::string. But that's not enough to invoke constructors of std::exception (and derivatives) if we don't have a reference to an std::string handy.
igaztanaga
added a commit
that referenced
this pull request
Dec 23, 2015
Member
|
Many thanks for the patch and the detailed report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure
std::stringconstructor is available because<stdexcept>only needs to have a forward declaration ofstd::string. But that's not enough to invoke constructors ofstd::exception(and derivatives) if we don't have a reference to anstd::stringhandy.This is necessary with STLport which only includes a forward declaration of
std::stringin<stdexcept>.