New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build reproducibility: Add .file section for *_elf_gas.S files #91

Closed
DouglasRoyds opened this Issue Nov 21, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@DouglasRoyds
Copy link

DouglasRoyds commented Nov 21, 2018

Add a .file directive to all *_elf_gas.S files to prevent the linker adding a host build-system path as a FILE symbol to the object file. Without this, the gnu linker adds a symbol like this:

0000000000000000 0 FILE LOCAL DEFAULT ABS /path/to/my/build/.../asm/make_x86_64_sysv_elf_gas.o

The attached file is a .patch file, but GitHub wouldn't upload it with the .patch extension:
0001-Reproducibility-Add-file-section-for-elf-gas-S-files.patch.txt

halstead pushed a commit to openembedded/openembedded-core that referenced this issue Nov 22, 2018

boost-context: Reproducibility: Set .file section for all *_elf_gas.S…
… files

Add a .file directive explicitly for all *_elf_gas.S files to prevent the linker
adding a host build-system path as a FILE symbol to the object file.

This replaces the existing patch that added the .file directive to a small
subset of these files.

Upstream-Status: Submitted [boostorg/context#91]
Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

kraj pushed a commit to kraj/poky that referenced this issue Nov 23, 2018

boost-context: Reproducibility: Set .file section for all *_elf_gas.S…
… files

Add a .file directive explicitly for all *_elf_gas.S files to prevent the linker
adding a host build-system path as a FILE symbol to the object file.

This replaces the existing patch that added the .file directive to a small
subset of these files.

Upstream-Status: Submitted [boostorg/context#91]
(From OE-Core rev: da9e7cad6144d2d49bc3d212bb317746875b8f04)

Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

kraj pushed a commit to kraj/poky that referenced this issue Nov 23, 2018

boost-context: Reproducibility: Set .file section for all *_elf_gas.S…
… files

Add a .file directive explicitly for all *_elf_gas.S files to prevent the linker
adding a host build-system path as a FILE symbol to the object file.

This replaces the existing patch that added the .file directive to a small
subset of these files.

Upstream-Status: Submitted [boostorg/context#91]
(From OE-Core rev: da9e7cad6144d2d49bc3d212bb317746875b8f04)

Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

kraj pushed a commit to kraj/poky that referenced this issue Nov 23, 2018

boost-context: Reproducibility: Set .file section for all *_elf_gas.S…
… files

Add a .file directive explicitly for all *_elf_gas.S files to prevent the linker
adding a host build-system path as a FILE symbol to the object file.

This replaces the existing patch that added the .file directive to a small
subset of these files.

Upstream-Status: Submitted [boostorg/context#91]
(From OE-Core rev: da9e7cad6144d2d49bc3d212bb317746875b8f04)

Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

kraj pushed a commit to kraj/poky that referenced this issue Nov 23, 2018

boost-context: Reproducibility: Set .file section for all *_elf_gas.S…
… files

Add a .file directive explicitly for all *_elf_gas.S files to prevent the linker
adding a host build-system path as a FILE symbol to the object file.

This replaces the existing patch that added the .file directive to a small
subset of these files.

Upstream-Status: Submitted [boostorg/context#91]
(From OE-Core rev: da9e7cad6144d2d49bc3d212bb317746875b8f04)

Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

halstead pushed a commit to openembedded/openembedded-core that referenced this issue Nov 23, 2018

boost-context: Reproducibility: Set .file section for all *_elf_gas.S…
… files

Add a .file directive explicitly for all *_elf_gas.S files to prevent the linker
adding a host build-system path as a FILE symbol to the object file.

This replaces the existing patch that added the .file directive to a small
subset of these files.

Upstream-Status: Submitted [boostorg/context#91]
Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

kraj pushed a commit to kraj/poky that referenced this issue Nov 24, 2018

boost-context: Reproducibility: Set .file section for all *_elf_gas.S…
… files

Add a .file directive explicitly for all *_elf_gas.S files to prevent the linker
adding a host build-system path as a FILE symbol to the object file.

This replaces the existing patch that added the .file directive to a small
subset of these files.

Upstream-Status: Submitted [boostorg/context#91]
(From OE-Core rev: 5ff5f89f2db079a6baf0275ebf1333b4b9642504)

Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

olk added a commit that referenced this issue Nov 24, 2018

Reproducibility: Set .file section for all *_elf_gas.S
- in context of #91

Add a .file directive to all *_elf_gas.S files to prevent the linker
adding a host build-system path as a FILE symbol to the object file.
Without this, the gnu linker adds a symbol like this:

thanks to Douglas Royds <douglas.royds@taitradio.com>
openembedded/openembedded-core
@olk

This comment has been minimized.

Copy link
Member

olk commented Nov 24, 2018

ty

@olk olk closed this Nov 24, 2018

halstead pushed a commit to openembedded/openembedded-core that referenced this issue Jan 8, 2019

boost-context: Reproducibility: Set .file section for all *_elf_gas.S…
… files

Add a .file directive explicitly for all *_elf_gas.S files to prevent the linker
adding a host build-system path as a FILE symbol to the object file.

This replaces the existing patch that added the .file directive to a small
subset of these files.

Upstream-Status: Submitted [boostorg/context#91]
(From OE-Core rev: 5ff5f89)

Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Armin Kuster <akuster808@gmail.com>

gc-plp pushed a commit to gc-plp/poky that referenced this issue Jan 8, 2019

boost-context: Reproducibility: Set .file section for all *_elf_gas.S…
… files

Add a .file directive explicitly for all *_elf_gas.S files to prevent the linker
adding a host build-system path as a FILE symbol to the object file.

This replaces the existing patch that added the .file directive to a small
subset of these files.

Upstream-Status: Submitted [boostorg/context#91]
(From OE-Core rev: 5ff5f89f2db079a6baf0275ebf1333b4b9642504)

(From OE-Core rev: 763398b87c257ab672430bedd01004b9317d02b2)

Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment