New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symbol already defined #20

Closed
jcfly opened this Issue Sep 12, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@jcfly

jcfly commented Sep 12, 2018

non template free functions in dll/detail/demangling/msvc.hpp are not inline, so they cannot be used by multiple cpp files, or there will be a link error "symbol already defined"

@apolukhin apolukhin added the bug label Sep 13, 2018

apolukhin added a commit that referenced this issue Sep 13, 2018

apolukhin added a commit that referenced this issue Sep 17, 2018

apolukhin added a commit that referenced this issue Sep 17, 2018

@apolukhin

This comment has been minimized.

Member

apolukhin commented Sep 18, 2018

Added fixes and test. Test passes on Linux and Windows. All the changes will be merged to master soon

@apolukhin apolukhin closed this Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment