Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default constructor non-explicit #48

Merged

Conversation

@kariya-mitsuru
Copy link
Contributor

commented Jun 10, 2019

IMHO, it is better to support copy-initialization with default constructor.

cf. LWG Issue 2193. Default constructors for standard library containers are explicit
link: https://wg21.cmeerw.net/lwg/issue2193

@kariya-mitsuru kariya-mitsuru force-pushed the kariya-mitsuru:make-default-ctor-non-explicit branch from e17808b to 8676ff4 Jun 10, 2019

@jeking3 jeking3 requested a review from glenfe Jun 11, 2019

include/boost/dynamic_bitset/dynamic_bitset.hpp Outdated Show resolved Hide resolved
dynamic_bitset.html Outdated Show resolved Hide resolved

@kariya-mitsuru kariya-mitsuru force-pushed the kariya-mitsuru:make-default-ctor-non-explicit branch from 8676ff4 to 5fd3aa7 Jun 12, 2019

@glenfe
Copy link
Member

left a comment

Just one documentation change, and then it looks good to me.

dynamic_bitset.html Outdated Show resolved Hide resolved
Make default constructor non-explicit
IMHO, it is better to support copy-initialization with default constructor.

cf. LWG Issue 2193. Default constructors for standard library containers are explicit
link: https://wg21.cmeerw.net/lwg/issue2193

@kariya-mitsuru kariya-mitsuru force-pushed the kariya-mitsuru:make-default-ctor-non-explicit branch from 5fd3aa7 to 0b47c75 Jun 12, 2019

@glenfe glenfe merged commit ab192ca into boostorg:develop Jun 12, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@glenfe

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

@kariya-mitsuru Thank you for the contribution.

@kariya-mitsuru kariya-mitsuru deleted the kariya-mitsuru:make-default-ctor-non-explicit branch Jun 13, 2019

@kariya-mitsuru

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

Thank you for your quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.