Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Update PGI C++ compiler support #49
There is no version check because we don't know of any customers who are still using a PGI compiler old enough to require that workaround. If there are any such users, there's a good chance that they also have an older version of Boost that won't have this change. In my opinion, the potential benefit of a version check is smaller than the cost of cluttering up the code.
(I am not Boost project member, nor have commit rights to Boost, just trying to contribute with the code review.)
I think, this pull request is nice and @dkolsen-pgi 's reasoning make sense. Old workarounds clutter the code and are liabilities. They should have finite lifetime. This workaround was committed in 2011 (commit d776d39). Time to retire it, IMO.
The pull request comes from an employee of the company which produces the PGI compiler, IIUC. Which gives the PR more credibility.
I am voting, for what it's worth, for this PR to be merged in.