New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PGI C++ compiler support #49

Merged
merged 1 commit into from Sep 6, 2018

Conversation

Projects
None yet
4 participants
@dkolsen-pgi
Contributor

dkolsen-pgi commented Jul 26, 2017

Remove an #if from operations.cpp that used to be necessary for the file to compile with PGI C++, but causes compilation errors with PGI C++ compilers of the last few years.

Update PGI C++ compiler support
Remove an #if from operations.cpp that used to be necessary for the file to compile with PGI C++, but causes compilation errors with PGI C++ compilers of the last few years.
@Lastique

This comment has been minimized.

Member

Lastique commented Jul 26, 2017

If the workaround is still needed for older versions, why not guard it with a version check?

@dkolsen-pgi

This comment has been minimized.

Contributor

dkolsen-pgi commented Jul 26, 2017

There is no version check because we don't know of any customers who are still using a PGI compiler old enough to require that workaround. If there are any such users, there's a good chance that they also have an older version of Boost that won't have this change. In my opinion, the potential benefit of a version check is smaller than the cost of cluttering up the code.

@alexeikh

This comment has been minimized.

Contributor

alexeikh commented May 11, 2018

(I am not Boost project member, nor have commit rights to Boost, just trying to contribute with the code review.)

I think, this pull request is nice and @dkolsen-pgi 's reasoning make sense. Old workarounds clutter the code and are liabilities. They should have finite lifetime. This workaround was committed in 2011 (commit d776d39). Time to retire it, IMO.

The pull request comes from an employee of the company which produces the PGI compiler, IIUC. Which gives the PR more credibility.

I am voting, for what it's worth, for this PR to be merged in.

@pdimov pdimov merged commit e560896 into boostorg:develop Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment