New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversion specifier support for 'A', 'a', and 'F' #41

merged 1 commit into from Oct 24, 2017


None yet
1 participant

jeking3 commented Oct 24, 2017

Using the format_matrix tool, I have ensured the only changes were for F, A, and a conversion specifiers. I did a little grouping/prettying-up the conversion specifier switch statement in code as part of this PR.

Note that F versus f really only matters when using the float constants INFINITY or NAN, however F is supported by ISO C99 so we're supporting it here as well.

With-Commit values are from msvc-14.1.

String Data Pre-Commit With-Commit
%F 1234567.890123f boost::bad_format_string: format-string is ill-formed 1234567.875000
%A 1234567.890123f boost::bad_format_string: format-string is ill-formed 0X1.2D687EP+20
%a 1234567.890123f boost::bad_format_string: format-string is ill-formed 0x1.2d687ep+20

This closes #30

@jeking3 jeking3 self-assigned this Oct 24, 2017

@jeking3 jeking3 added the enhancement label Oct 24, 2017

@jeking3 jeking3 added this to the v1.66.0 milestone Oct 24, 2017

@jeking3 jeking3 merged commit 280b3f3 into boostorg:develop Oct 24, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@jeking3 jeking3 deleted the jeking3:issue-30 branch Oct 24, 2017

jeking3 pushed a commit to jeking3/format that referenced this pull request Jun 17, 2018

Merge pull request boostorg#41 from Lastique/fix_years_overflow
Fixed integer overflow when adding many years to a gregorian date.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment