Skip to content

Removed deprecated std::allocator<void> #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Removed deprecated std::allocator<void> #70

wants to merge 1 commit into from

Conversation

bansan85
Copy link

@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@894f465). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #70   +/-   ##
==========================================
  Coverage           ?   67.73%           
==========================================
  Files              ?       10           
  Lines              ?      877           
  Branches           ?      300           
==========================================
  Hits               ?      594           
  Misses             ?      111           
  Partials           ?      172
Impacted Files Coverage Δ
include/boost/format/alt_sstream_impl.hpp 23.52% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 894f465...e47eef3. Read the comment docs.

@jeking3
Copy link
Collaborator

jeking3 commented Mar 4, 2020

Likely need a CI test variant that uses BOOST_NO_CXX11_ALLOCATOR to prove this out. In fact this is probably true of many of the preprocessor branches around boost... will consider that. Thanks for the submit; I've been bootstrapping a new startup so sorry for the delay.

jwakely
jwakely reviewed Mar 30, 2020
View reviewed changes
include/boost/format/alt_sstream_impl.hpp
void *vdptr = alloc_.allocate(new_size, is_allocated_? oldptr : 0);
#else
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this combination possible? I would not expect the RW lib without class template partial specializations to support allocator_traits at all.

jwakely
jwakely reviewed Mar 30, 2020
View reviewed changes
Copy link

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the pull request seems wrong, this has nothing to do with std::allocator<void>, it's the fact that std::allocator<T>::allocate no longer accepts a hint argument in C++20.

@jwakely
Copy link

jwakely commented Mar 30, 2020

And shouldn't line 44 get fixed too?

@glenfe
Copy link
Member

glenfe commented May 31, 2020

Covered by 5884c3d.

@glenfe glenfe closed this May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jwakely jwakely jwakely left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Direct use of Allocator::allocate is deprecated in C++17
4 participants
@bansan85 @jeking3 @jwakely @glenfe