Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BOOST_CONSTEXPR on BOOST_FUSION_DEFINE_STRUCT #70

Merged
merged 1 commit into from Apr 21, 2015

Conversation

@daminetreg
Copy link
Contributor

commented Apr 21, 2015

Remove BOOST_CONSTEXPR on BOOST_FUSION_DEFINE_STRUCT constructors as it however adds the requirement that the user provided types are constant enabled.

Relates to https://svn.boost.org/trac/boost/ticket/11211

…t however adds the requirement that the user provided types are constant enabled.
djowel added a commit that referenced this pull request Apr 21, 2015
Remove BOOST_CONSTEXPR on BOOST_FUSION_DEFINE_STRUCT
@djowel djowel merged commit 294a5ce into boostorg:master Apr 21, 2015
@Flast

This comment has been minimized.

Copy link
Collaborator

commented Apr 21, 2015

Thanks @daminetreg !

I didn't check other variations but is this enough?

@daminetreg

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2015

Compiled for me with the example of the list. Perhaps we have more work somewhere.

@daminetreg

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2015

But I couldn't find it out.

@daminetreg

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2015

@Flast I've let constexpr for empty struct, do you also think it's ok ? On line 290 https://github.com/boostorg/fusion/blob/master/include/boost/fusion/adapted/struct/detail/define_struct.hpp#L290

I think BOOST_FUSION_DEFINE_STRUCT_INLINE could also have problems.

@Flast

This comment has been minimized.

Copy link
Collaborator

commented Apr 21, 2015

I've let constexpr for empty struct, do you also think it's ok ?

It seems good.

I think BOOST_FUSION_DEFINE_STRUCT_INLINE could also have problems.

Sorry, I'm moving now and I can't ensure duration for investigating...

@daminetreg daminetreg deleted the daminetreg:feature/fix-for-11211 branch Apr 26, 2015
@Flast Flast referenced this pull request May 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.