Jump to conversation
Unresolved conversations (4)
@awulkiew awulkiew Jul 4, 2018
Typically one should use `boost::range_reference<Range const>::type` to get reference for const range. Why not in this case?
Outdated
...t/geometry/iterators/closing_iterator.hpp
awulkiew jonasdmentia
@mkaravel mkaravel Jun 7, 2018
Same comment here.
Outdated
...etry/iterators/ever_circling_iterator.hpp
@mkaravel mkaravel Jun 7, 2018
I think the proper way to define those is to use the types from the `iterator_facade` class. Same for `difference_type`.
Outdated
...t/geometry/iterators/closing_iterator.hpp
jonasdmentia mkaravel
@mkaravel mkaravel Jun 7, 2018
Why did you need to modify this line? I would expect the ever_circling range iterator to work with or with out the ``const``.
test/iterators/ever_circling_iterator.cpp
jonasdmentia
Resolved conversations (0)