[strategies] [test] Fix spherical cross track and convex hull tests #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barendgehrels
approved these changes
Dec 22, 2020
Collaborator
barendgehrels
left a comment
barendgehrels
left a comment
There was a problem hiding this comment.
Looks OK but I don't know the reason to exclude convex hull tests.
| [ run convert_multi.cpp : : : : algorithms_convert_multi ] | ||
| [ run convex_hull.cpp : : : : algorithms_convex_hull ] | ||
| [ run convex_hull_multi.cpp : : : : algorithms_convex_hull_multi ] | ||
| [ run correct.cpp : : : : algorithms_correct ] |
Collaborator
There was a problem hiding this comment.
So it's gone? Will it be fixed later?
Member
Author
There was a problem hiding this comment.
No, they are moved in a convex_hull directory, see eae06f7
Collaborator
There was a problem hiding this comment.
No, they are moved in a
convex_hulldirectory, see eae06f7
I remember now, the big PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some tests that fail after merging #756
See also https://app.circleci.com/pipelines/github/vissarion/geometry/58/workflows/44e84067-89f7-4938-947f-006156956840