New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for three color types of PNG with tRNS chunk #125
Add test for three color types of PNG with tRNS chunk #125
Conversation
bc501a1
to
15d84c8
Compare
15d84c8
to
a4b1d3d
Compare
Is the image read correctly? |
@chhenning It is read successfully, without any exception about incompatibility. It also causes reading of the tRNS chunks, then setting That is all I observe. I haven't tried to verify if the image is read correctly. |
a4b1d3d
to
a08f30d
Compare
NOTE: None of the CI builds run the |
@stefanseefeld & @chhenning any feedback on this one? |
a08f30d
to
9b20f61
Compare
9b20f61
to
82b471c
Compare
In order to properly test From http://www.libpng.org/pub/png/spec/1.2/PNG-Chunks.html:
|
82b471c
to
8d6d783
Compare
8d6d783
to
0b1da32
Compare
0b1da32
to
4e6599e
Compare
The tests cover issue boostorg#117 and pull request boostorg#118, extending the coverage for all color types that may have tRNS chunks: - color type 0 (grayscale), the tRNS chunk contains a single gray level - color type 2 (truecolor), the tRNS chunk contains a single RGB color - color type 3 (indexed color), the tRNS chunk contains a series of one-byte alpha values Add sample PNG files from the "official" test-suite for PNG created by Willem van Schaik. Add <define>BOOST_GIL_IO_TEST_ALLOW_READING_IMAGES to Jamfile for PNG tests. NOTE: Deliberately not defined BOOST_GIL_IO_TEST_ALLOW_WRITING_IMAGES as it seems to require some extra configuration, currently it causes some tests to fail. So, Jamfile likely needs more updates and clean-up. Closes boostorg#120
4e6599e
to
01b02ee
Compare
Following second round of research, #125 (comment) around a month ago, the test received collection of PNG files with the variety of Despite long time, no reviews have arrived, so I'm going to merge it. |
The tests cover issue #117 and pull request #118, extending the coverage
for all color types that may have tRNS chunks:
one-byte alpha values
Add sample PNG files from the "official" test-suite for PNG created by Willem van Schaik.
Add
<define>BOOST_GIL_IO_TEST_ALLOW_READING_IMAGES
to Jamfile for PNG tests.NOTE: Deliberately not defined
BOOST_GIL_IO_TEST_ALLOW_WRITING_IMAGES
as it seems to require some extra configuration, currently it causes some tests to fail. So, Jamfile likely needs more updates and clean-up.References
Tasklist