Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests of extensions inside test/ directory #302

Merged

Conversation

@mloskot
Copy link
Member

mloskot commented May 27, 2019

Split header tests accordingly i.e. test core headers as part of
core tests, numeric extension headers as part of numeric tests, etc.

It extends the convention of sub-directories already established in
include/boost/gil directory. It is sensible to follow it in other
areas of the source tree (i.e. test/, doc/ and benchmark/).

Another important reason to move the tests is to enable removal of
the top-level Jamfile with all its definitions of test-specific
requirements.
The top-level Jamfile is not advised, especially if it specifies
build requirements like C++ language version.
Those affect non-tests builds e.g. documentation, causing failures
during generation of HTML documentation (leads to missing docs).

References

  • Changes in #260 broke build of the docs during global docs build.

Tasklist

  • Update Boost.Build configuration in Jamfile-s
  • Update CMake configuration CMakeLists.txt-s
  • Ensure all CI builds pass
  • Review and approve

FYI, The unwanted top-level Jamfile has been confirmed (by @djarek and @pdimov) as what caused GIL docs build failures and not publishing them as part of Boost 1.70 docs.

@mloskot mloskot requested a review from stefanseefeld May 27, 2019
@mloskot mloskot self-assigned this May 27, 2019
@mloskot mloskot force-pushed the mloskot:ml/move-extension-tests-into-test-dir branch 4 times, most recently from 22a5da5 to 8cd1f0d May 28, 2019
Split header tests accordingly i.e. test core headers as part of
core tests, numeric extension headers as part of numeric tests, etc.

It extends the convention of sub-directories already established in
`include/boost/gil` directory. It is sensible to follow it in other
areas of the source tree (i.e. `test/`, `doc/` and `benchmark/`).

Another important reason to move the tests is to enable removal of
the top-level `Jamfile` with all its definitions of test-specific
requirements.
The top-level `Jamfile` is not advised, especially if it specifies
build requirements like C++ language version.
Those affect non-tests builds e.g. documentation, causing failures
during generation of HTML documentation (leads to missing docs).
@mloskot mloskot force-pushed the mloskot:ml/move-extension-tests-into-test-dir branch from 8cd1f0d to 3260f1a May 28, 2019
@mloskot mloskot added this to the Boost 1.71 milestone May 28, 2019
@mloskot mloskot merged commit 4ed7701 into boostorg:develop May 28, 2019
9 checks passed
9 checks passed
boostorg.gil Build #20190528.5 succeeded
Details
boostorg.gil (macos1013_xcode91_cmake) macos1013_xcode91_cmake succeeded
Details
boostorg.gil (ubuntu1604_gcc5_cxx11_cmake) ubuntu1604_gcc5_cxx11_cmake succeeded
Details
boostorg.gil (ubuntu1604_gcc8_cxx14_cmake) ubuntu1604_gcc8_cxx14_cmake succeeded
Details
boostorg.gil (win2012_vs2015_cmake) win2012_vs2015_cmake succeeded
Details
boostorg.gil (win2016_vs2017_cxx14_cmake) win2016_vs2017_cxx14_cmake succeeded
Details
boostorg.gil (win2016_vs2017_cxx17_cmake) win2016_vs2017_cxx17_cmake succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mloskot mloskot deleted the mloskot:ml/move-extension-tests-into-test-dir branch May 28, 2019
@mloskot

This comment has been minimized.

Copy link
Member Author

mloskot commented May 28, 2019

@stefanseefeld We may have to merge into master sooner to get this change (and fix the docs build).

This looks good now
https://www.boost.org/doc/libs/develop/libs/gil/doc/html/index.html
whereas this does not
https://www.boost.org/doc/libs/master/libs/gil/doc/html/index.html

mloskot added a commit that referenced this pull request May 28, 2019
Related to #302
mloskot added a commit to mloskot/gil that referenced this pull request Sep 26, 2019
Split header tests accordingly i.e. test core headers as part of
core tests, numeric extension headers as part of numeric tests, etc.

It extends the convention of sub-directories already established in
`include/boost/gil` directory. It is sensible to follow it in other
areas of the source tree (i.e. `test/`, `doc/` and `benchmark/`).

Another important reason to move the tests is to enable removal of
the top-level `Jamfile` with all its definitions of test-specific
requirements.
The top-level `Jamfile` is not advised, especially if it specifies
build requirements like C++ language version.
Those affect non-tests builds e.g. documentation, causing failures
during generation of HTML documentation (leads to missing docs).

(cherry picked from develop branch commit 4ed7701)
mloskot added a commit to mloskot/gil that referenced this pull request Sep 26, 2019
Related to boostorg#302

(cherry picked from commit 628bfc2)
mloskot added a commit to mloskot/gil that referenced this pull request Sep 26, 2019
Split header tests accordingly i.e. test core headers as part of
core tests, numeric extension headers as part of numeric tests, etc.

It extends the convention of sub-directories already established in
`include/boost/gil` directory. It is sensible to follow it in other
areas of the source tree (i.e. `test/`, `doc/` and `benchmark/`).

Another important reason to move the tests is to enable removal of
the top-level `Jamfile` with all its definitions of test-specific
requirements.
The top-level `Jamfile` is not advised, especially if it specifies
build requirements like C++ language version.
Those affect non-tests builds e.g. documentation, causing failures
during generation of HTML documentation (leads to missing docs).

(cherry picked from develop branch commit 4ed7701)
mloskot added a commit to mloskot/gil that referenced this pull request Sep 26, 2019
Related to boostorg#302

(cherry picked from develop branch commit 628bfc2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.