Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harris response computation #350

Merged
merged 5 commits into from Aug 21, 2019
Merged

Harris response computation #350

merged 5 commits into from Aug 21, 2019

Conversation

@simmplecoder
Copy link
Contributor

simmplecoder commented Jul 23, 2019

Description

Implement Harris corner detection, but without suggested result filtering. The algorithm writes Harris responses into gray32_view_t and the user can apply their chosen filtering/suppression algorithms. Loosening filtering will give edge detector.

Environment

Everything compatible with Boost 1.70

References

https://en.wikipedia.org/wiki/Harris_Corner_Detector

https://en.wikipedia.org/wiki/Structure_tensor

https://en.wikipedia.org/wiki/Image_derivatives

http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.434.4816&rep=rep1&type=pdf

Tasklist

  • Implement Harris corner detection algorithm
  • Extract contents of current test file into demo
  • Add test cases (simplistic for now)
  • Write docs that would be readable for most people Will be covered by another PR.
  • Ensure all CI builds pass
  • Review and approve
@simmplecoder simmplecoder requested a review from stefanseefeld Jul 23, 2019
@simmplecoder simmplecoder changed the title Restore previous state of Harris Harris response computation Jul 23, 2019
Copy link
Member

mloskot left a comment

@simmplecoder I've taken the liberty of requesting a few clarifications and cleanups

include/boost/gil/image_processing/harris.hpp Outdated Show resolved Hide resolved
include/boost/gil/image_processing/harris.hpp Outdated Show resolved Hide resolved
include/boost/gil/image_processing/harris.hpp Outdated Show resolved Hide resolved
include/boost/gil/image_processing/harris.hpp Outdated Show resolved Hide resolved
example/harris.cpp Outdated Show resolved Hide resolved
example/harris.cpp Outdated Show resolved Hide resolved
example/harris.cpp Outdated Show resolved Hide resolved
example/harris.cpp Outdated Show resolved Hide resolved
@simmplecoder simmplecoder force-pushed the simmplecoder:harris branch from a75df96 to f3033e9 Jul 26, 2019
@simmplecoder simmplecoder mentioned this pull request Aug 3, 2019
4 of 6 tasks complete
@simmplecoder simmplecoder force-pushed the simmplecoder:harris branch from f3033e9 to 82ae359 Aug 9, 2019
@simmplecoder

This comment has been minimized.

Copy link
Contributor Author

simmplecoder commented Aug 9, 2019

@stefanseefeld , if you don't have any more suggestions, could you please approve the PR? Last commit introduced license and copyright notices. Design PR will come as a different PR.

This is a fresh start of branch
Harris with manual copying and
placement of code from previous
versions
Weights passed as arguments were not
used prior to this commit
Mostly moving brackets and adding
const, but also address MSVC's
max macro
In file numeric.hpp, there is
full qualification, but harris.hpp
didn't have full qualification,
thus full qualification is added to
harris.hpp
@simmplecoder simmplecoder force-pushed the simmplecoder:harris branch from 82ae359 to 69ad0b0 Aug 20, 2019
@simmplecoder simmplecoder merged commit 65fda3c into boostorg:develop Aug 21, 2019
9 checks passed
9 checks passed
boostorg.gil Build #20190820.4 succeeded
Details
boostorg.gil (macos1013_xcode91_cmake) macos1013_xcode91_cmake succeeded
Details
boostorg.gil (ubuntu1604_gcc5_cxx11_cmake) ubuntu1604_gcc5_cxx11_cmake succeeded
Details
boostorg.gil (ubuntu1604_gcc8_cxx14_cmake) ubuntu1604_gcc8_cxx14_cmake succeeded
Details
boostorg.gil (win2012_vs2015_cmake) win2012_vs2015_cmake succeeded
Details
boostorg.gil (win2016_vs2017_cxx14_cmake) win2016_vs2017_cxx14_cmake succeeded
Details
boostorg.gil (win2016_vs2017_cxx17_cmake) win2016_vs2017_cxx17_cmake succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@simmplecoder simmplecoder mentioned this pull request Aug 31, 2019
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.