Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harris response computation #350

Merged
merged 5 commits into from Aug 21, 2019
Merged

Harris response computation #350

merged 5 commits into from Aug 21, 2019

Conversation

simmplecoder
Copy link
Contributor

@simmplecoder simmplecoder commented Jul 23, 2019

Description

Implement Harris corner detection, but without suggested result filtering. The algorithm writes Harris responses into gray32_view_t and the user can apply their chosen filtering/suppression algorithms. Loosening filtering will give edge detector.

Environment

Everything compatible with Boost 1.70

References

https://en.wikipedia.org/wiki/Harris_Corner_Detector

https://en.wikipedia.org/wiki/Structure_tensor

https://en.wikipedia.org/wiki/Image_derivatives

http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.434.4816&rep=rep1&type=pdf

Tasklist

  • Implement Harris corner detection algorithm
  • Extract contents of current test file into demo
  • Add test cases (simplistic for now)
  • Write docs that would be readable for most people Will be covered by another PR.
  • Ensure all CI builds pass
  • Review and approve

@simmplecoder simmplecoder requested a review from stefanseefeld Jul 23, 2019
@simmplecoder simmplecoder changed the title Restore previous state of Harris Harris response computation Jul 23, 2019
Copy link
Member

@mloskot mloskot left a comment

@simmplecoder I've taken the liberty of requesting a few clarifications and cleanups

include/boost/gil/image_processing/harris.hpp Outdated Show resolved Hide resolved
include/boost/gil/image_processing/harris.hpp Outdated Show resolved Hide resolved
include/boost/gil/image_processing/harris.hpp Outdated Show resolved Hide resolved
include/boost/gil/image_processing/harris.hpp Outdated Show resolved Hide resolved
example/harris.cpp Outdated Show resolved Hide resolved
example/harris.cpp Outdated Show resolved Hide resolved
example/harris.cpp Outdated Show resolved Hide resolved
example/harris.cpp Outdated Show resolved Hide resolved
@mloskot mloskot added the cat/feature label Jul 23, 2019
@simmplecoder
Copy link
Contributor Author

@simmplecoder simmplecoder commented Aug 9, 2019

@stefanseefeld , if you don't have any more suggestions, could you please approve the PR? Last commit introduced license and copyright notices. Design PR will come as a different PR.

This is a fresh start of branch
Harris with manual copying and
placement of code from previous
versions
Weights passed as arguments were not
used prior to this commit
Mostly moving brackets and adding
const, but also address MSVC's
max macro
In file numeric.hpp, there is
full qualification, but harris.hpp
didn't have full qualification,
thus full qualification is added to
harris.hpp
@simmplecoder simmplecoder merged commit 65fda3c into boostorg:develop Aug 21, 2019
9 checks passed
@simmplecoder simmplecoder mentioned this pull request Aug 31, 2019
3 tasks
@mloskot mloskot moved this from In progress to Done in [gsoc2019] Epipolar Geometry Fundamentals Jan 14, 2020
@mloskot mloskot added the google-summer-of-code label Feb 22, 2020
@simmplecoder simmplecoder deleted the harris branch Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/feature google-summer-of-code
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants