Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hessian corner detector #364

Merged
merged 11 commits into from Aug 21, 2019
Merged

Hessian corner detector #364

merged 11 commits into from Aug 21, 2019

Conversation

@simmplecoder
Copy link
Contributor

simmplecoder commented Aug 3, 2019

Description

This commit implements Hessian corner detector, with response function being the same as in Harris.

Compatibility

Anything compatible with Boost 1.70

References

https://en.wikipedia.org/wiki/Hessian_matrix

Tasklist

  • Implement Hessian corner detection algorithm
  • Add inline docs
  • Add larger docs to explain the algorithm better will be covered by another PR
  • Add test cases
  • Ensure all CI builds pass
  • Review and approve
@mloskot

This comment has been minimized.

Copy link
Member

mloskot commented Aug 9, 2019

@simmplecoder I know close to nothing about Hessian detector. I can only offer a nitpicking C++ guidelines/style review. Do you still wish to have one?

@simmplecoder

This comment has been minimized.

Copy link
Contributor Author

simmplecoder commented Aug 10, 2019

@mloskot , yes, any constructive criticism is welcome! (Boost guidelines, GIL guidelines, any other concerns).

@simmplecoder simmplecoder force-pushed the simmplecoder:hessian branch from 26acd98 to ecf3f47 Aug 10, 2019
example/hessian.cpp Outdated Show resolved Hide resolved
example/hessian.cpp Outdated Show resolved Hide resolved
example/hessian.cpp Outdated Show resolved Hide resolved
example/hessian.cpp Outdated Show resolved Hide resolved
example/hessian.cpp Outdated Show resolved Hide resolved
example/hessian.cpp Show resolved Hide resolved
include/boost/gil/image_processing/numeric.hpp Outdated Show resolved Hide resolved
test/core/image_processing/hessian.cpp Show resolved Hide resolved
example/hessian.cpp Outdated Show resolved Hide resolved
example/hessian.cpp Outdated Show resolved Hide resolved
@simmplecoder simmplecoder force-pushed the simmplecoder:hessian branch from 8b194ae to 1ea7915 Aug 20, 2019
simmplecoder added 11 commits Aug 3, 2019
This commit partially implements
Hessian corner detector, but only
uses determinant as Hessian response
This commit complements last one
by summing in a window and applying
det - k * trace * trace formula to
final Hessian response
This commit adds docs to new functions,
and makes function and variable names
align with docs to not confuse readers
A-KAZE uses only determinant in it's
response, and since for now Hessian
is only a mean to advance A-KAZE
implementation, response function is
adjusted to use only determinant
This commit adds an s at the end of
function name to make it uniform with
another detector, and adds a simple
test for sanity check
dx and similar naming seems to be
confusing, improved documentation
to explain the naming convention
Mostly changes to constness and
integral types, with small cosmetic
changes mixed in
Fixes typo in call for Hessian and
addresses a review comment about
replacing multiple exact indexing
calls to one with a reference
Add literature reference to luminosity
computation, and perform some cosmetic
changes.
@simmplecoder simmplecoder force-pushed the simmplecoder:hessian branch from 1ea7915 to b232d89 Aug 21, 2019
@simmplecoder simmplecoder merged commit 5c52dff into boostorg:develop Aug 21, 2019
9 checks passed
9 checks passed
boostorg.gil Build #20190821.2 succeeded
Details
boostorg.gil (macos1013_xcode91_cmake) macos1013_xcode91_cmake succeeded
Details
boostorg.gil (ubuntu1604_gcc5_cxx11_cmake) ubuntu1604_gcc5_cxx11_cmake succeeded
Details
boostorg.gil (ubuntu1604_gcc8_cxx14_cmake) ubuntu1604_gcc8_cxx14_cmake succeeded
Details
boostorg.gil (win2012_vs2015_cmake) win2012_vs2015_cmake succeeded
Details
boostorg.gil (win2016_vs2017_cxx14_cmake) win2016_vs2017_cxx14_cmake succeeded
Details
boostorg.gil (win2016_vs2017_cxx17_cmake) win2016_vs2017_cxx17_cmake succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@simmplecoder simmplecoder mentioned this pull request Aug 31, 2019
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.