New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add convolve_2d function to numeric extension #367
Conversation
46787c9
to
9a008e0
Compare
@miralshah365 Do you plan to work on more test cases? |
fe65306
to
7eff290
Compare
Generally it looks good. I just have several minor requests.
Could you add comment documenting any constraints and limitations of the current convolve_2d
implementation. That is:
(Source http://www.songho.ca/dsp/convolution/convolution2d_example.html)
In particular, how it handles the boundary pixels. Ideally, if referenced to/contrasted with/named after the convolve_1d
modes:
gil/include/boost/gil/extension/numeric/convolve.hpp
Lines 35 to 42 in 8815ab0
enum /*class*/ convolve_boundary_option | |
{ | |
convolve_option_output_ignore, /// do nothing to the output | |
convolve_option_output_zero, /// set the output to zero | |
convolve_option_extend_padded, /// assume the source boundaries to be padded already | |
convolve_option_extend_zero, /// assume the source boundaries to be zero | |
convolve_option_extend_constant /// assume the source boundaries to be the boundary value | |
}; |
I hope it makes sense.
The current implementation of |
@miralshah365 LGTM! Feel free to merge as soon as all CI-s are green.
} //namespace detail | ||
|
||
/*! | ||
convolve_2d can only use convolve_option_extend_zero as convolve_boundary_option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miralshah365 Please, don't forget to open an issue with list your ideas and wishes about what can be improved in the convolve_2d
. It will be useful record.
@miralshah365 Let's resolve this new discussion with @lpranam before merging #367 (review)
Also, you need to update your branch and resolve the little conflict in the build scripts.
2D convolution tests added `convolve` function renamed to `convolve_1d` closes boostorg#356
@miralshah365 LGTM. Feel free to merge.
@lpranam Thank you for offering valuable feedback!
@miralshah365 also please don't forget about #367 (comment) |
Description
convolve
function renamed toconvolve_1d
for more detail check the reference(s)
References
closes #356
Tasklist