Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementatin of box filter and blur #383

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@miralshah365
Copy link
Contributor

miralshah365 commented Aug 15, 2019

Description

implemented blur function

tests added for box_filter

This utility will provide a way to remove noise from the image using convolution with average kernel(normalized and unnormalized).

It also provides blur function which works only with normalized mean kernels

References

closes #382

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve
@miralshah365 miralshah365 added this to the Boost 1.72+ milestone Aug 15, 2019
@miralshah365 miralshah365 requested a review from mloskot Aug 15, 2019
@miralshah365 miralshah365 self-assigned this Aug 15, 2019
@mloskot mloskot marked this pull request as ready for review Aug 18, 2019
@mloskot mloskot changed the title implemented `box_filter` Add implementatin of box filter and blur Aug 18, 2019
Copy link
Member

mloskot left a comment

@miralshah365 LGTM. Feel free to merge.

@mloskot mloskot dismissed their stale review Aug 18, 2019

There is an important build configuration missing

Copy link
Member

mloskot left a comment

run box_filter.cpp ; entry is missing from here:

run threshold_binary.cpp ;

Currently, the box_filter.cpp test is not compiled on Jamfile-only CI jobs on Travis CI and AppVeyor.

@miralshah365 miralshah365 force-pushed the miralshah365:box_filter branch from ec30419 to baebe52 Aug 18, 2019
Copy link
Member

mloskot left a comment

@miralshah365 There is one request for change to fix the test linking error

test/core/image_processing/Jamfile Outdated Show resolved Hide resolved
@miralshah365 miralshah365 force-pushed the miralshah365:box_filter branch from baebe52 to f1118e2 Aug 19, 2019
@miralshah365 miralshah365 requested a review from mloskot Aug 20, 2019
Copy link
Member

mloskot left a comment

@miralshah365 looks good, feel free to merge.

Looks like you'll need to resolve conflict

implemented `blur` function

tests added for `box_filter`

closes #382
@miralshah365 miralshah365 force-pushed the miralshah365:box_filter branch from f1118e2 to 27d9d53 Aug 21, 2019
@miralshah365 miralshah365 merged commit 124f621 into boostorg:develop Aug 21, 2019
9 checks passed
9 checks passed
boostorg.gil Build #20190821.4 succeeded
Details
boostorg.gil (macos1013_xcode91_cmake) macos1013_xcode91_cmake succeeded
Details
boostorg.gil (ubuntu1604_gcc5_cxx11_cmake) ubuntu1604_gcc5_cxx11_cmake succeeded
Details
boostorg.gil (ubuntu1604_gcc8_cxx14_cmake) ubuntu1604_gcc8_cxx14_cmake succeeded
Details
boostorg.gil (win2012_vs2015_cmake) win2012_vs2015_cmake succeeded
Details
boostorg.gil (win2016_vs2017_cxx14_cmake) win2016_vs2017_cxx14_cmake succeeded
Details
boostorg.gil (win2016_vs2017_cxx17_cmake) win2016_vs2017_cxx17_cmake succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
[gsoc2019] Image Processing Algorithms automation moved this from In progress to Done Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.