New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementatin of box filter and blur #383

Merged

miralshah365 merged 1 commit into boostorg:develop from miralshah365:box_filter

Aug 21, 2019

Contributor

miralshah365 commented Aug 15, 2019 •

edited

Description

implemented blur function

tests added for box_filter

This utility will provide a way to remove noise from the image using convolution with average kernel(normalized and unnormalized).

It also provides blur function which works only with normalized mean kernels

References

closes #382

Tasklist

Add test case(s)
Ensure all CI builds pass
Review and approve

miralshah365 added the cat/feature label

miralshah365 added this to the Boost 1.72+ milestone

miralshah365 requested a review from mloskot

miralshah365 self-assigned this

mloskot marked this pull request as ready for review

mloskot changed the title ~~implemented `box_filter`~~ Add implementatin of box filter and blur

mloskot reviewed

Member

mloskot left a comment

@miralshah365 LGTM. Feel free to merge.

mloskot added this to In progress in [gsoc2019] Image Processing Algorithms

mloskot dismissed their stale review

There is an important build configuration missing

mloskot requested changes

Member

mloskot left a comment

run box_filter.cpp ; entry is missing from here:

gil/test/core/image_processing/Jamfile

Line 17 in ec30419

run threshold_binary.cpp ;

Currently, the box_filter.cpp test is not compiled on Jamfile-only CI jobs on Travis CI and AppVeyor.

mloskot reviewed

include/boost/gil/image_processing/filter.hpp Show resolved Hide resolved

mloskot reviewed

include/boost/gil/image_processing/filter.hpp Outdated Show resolved Hide resolved

mloskot reviewed

test/core/image_processing/box_filter.cpp Outdated Show resolved Hide resolved

mloskot reviewed

include/boost/gil/image_processing/filter.hpp Outdated Show resolved Hide resolved

miralshah365 force-pushed the miralshah365:box_filter branch from ec30419 to baebe52

mloskot requested changes

Member

mloskot left a comment

@miralshah365 There is one request for change to fix the test linking error

test/core/image_processing/Jamfile Outdated Show resolved Hide resolved

miralshah365 force-pushed the miralshah365:box_filter branch from baebe52 to f1118e2

miralshah365 requested a review from mloskot

mloskot approved these changes

Member

mloskot left a comment •

edited

@miralshah365 looks good, feel free to merge.

Looks like you'll need to resolve conflict


        implemented `box_filter`

27d9d53

implemented `blur` function

tests added for `box_filter`

closes #382

miralshah365 force-pushed the miralshah365:box_filter branch from f1118e2 to 27d9d53

miralshah365 merged commit 124f621 into boostorg:develop

9 checks passed

9 checks passed

boostorg.gil Build #20190821.4 succeeded

Details

boostorg.gil (macos1013_xcode91_cmake) macos1013_xcode91_cmake succeeded

Details

boostorg.gil (ubuntu1604_gcc5_cxx11_cmake) ubuntu1604_gcc5_cxx11_cmake succeeded

Details

boostorg.gil (ubuntu1604_gcc8_cxx14_cmake) ubuntu1604_gcc8_cxx14_cmake succeeded

Details

boostorg.gil (win2012_vs2015_cmake) win2012_vs2015_cmake succeeded

Details

boostorg.gil (win2016_vs2017_cxx14_cmake) win2016_vs2017_cxx14_cmake succeeded

Details

boostorg.gil (win2016_vs2017_cxx17_cmake) win2016_vs2017_cxx17_cmake succeeded

Details

continuous-integration/appveyor/pr AppVeyor build succeeded

Details

continuous-integration/travis-ci/pr The Travis CI build passed

Details

[gsoc2019] Image Processing Algorithms automation moved this from In progress to Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.