New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add implementatin of box filter and blur #383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
box_filter
mloskot
requested changes
Aug 18, 2019
run box_filter.cpp ;
entry is missing from here:
gil/test/core/image_processing/Jamfile
Line 17 in ec30419
run threshold_binary.cpp ; |
Currently, the box_filter.cpp
test is not compiled on Jamfile-only CI jobs on Travis CI and AppVeyor.
mloskot
reviewed
Aug 18, 2019
mloskot
reviewed
Aug 18, 2019
mloskot
reviewed
Aug 18, 2019
mloskot
reviewed
Aug 18, 2019
mloskot
requested changes
Aug 18, 2019
@miralshah365 There is one request for change to fix the test linking error
mloskot
approved these changes
Aug 21, 2019
@miralshah365 looks good, feel free to merge.
Looks like you'll need to resolve conflict
implemented `blur` function tests added for `box_filter` closes boostorg#382
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
implemented
blur
functiontests added for
box_filter
This utility will provide a way to remove noise from the image using convolution with
average
kernel(normalized and unnormalized).It also provides
blur
function which works only with normalized mean kernelsReferences
closes #382
Tasklist