Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image boundary extension algorithm added #386

Merged
merged 1 commit into from Sep 5, 2019

Conversation

@lpranam
Copy link
Contributor

lpranam commented Aug 30, 2019

Description

A new algorithm for image boundary extension added.
This can help with simplifying algorithms like convolution and median filter which is being implemented by @miralshah365.

While extending current convolve_2d this will allow all type of convolve options to be accommodated easily and current convolve_1d and also use to this to provide a uniform implementation.

References

#381

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve
Copy link
Member

mloskot left a comment

The documentation is a bit modest.

I understand these are quite simple operations, but a user may expect to get description of motivation, when to use it (e.g. is it a sort of a method for canvas resize while keeping image content intact), what are (input) limitations if any, etc.

@lpranam lpranam force-pushed the lpranam:boundary_extension branch from 68d223b to 3182d7e Sep 3, 2019
@lpranam

This comment has been minimized.

Copy link
Contributor Author

lpranam commented Sep 3, 2019

Added description as you suggested.
Took reference from this link:
https://caligari.dartmouth.edu/doc/idl/html_6.2/Padding_Images.html

Copy link
Member

mloskot left a comment

Thanks for linking the reference, it's an interesting resource.

I just have several requests for minor clean-ups (better to take care of it now than after merge).

include/boost/gil/extension/numeric/algorithm.hpp Outdated Show resolved Hide resolved
include/boost/gil/extension/numeric/algorithm.hpp Outdated Show resolved Hide resolved
include/boost/gil/extension/numeric/algorithm.hpp Outdated Show resolved Hide resolved
include/boost/gil/extension/numeric/algorithm.hpp Outdated Show resolved Hide resolved
include/boost/gil/extension/numeric/algorithm.hpp Outdated Show resolved Hide resolved
include/boost/gil/extension/numeric/algorithm.hpp Outdated Show resolved Hide resolved
include/boost/gil/extension/numeric/algorithm.hpp Outdated Show resolved Hide resolved
@mloskot mloskot added this to the Boost 1.72+ milestone Sep 4, 2019
@lpranam lpranam force-pushed the lpranam:boundary_extension branch from 3182d7e to aae0599 Sep 4, 2019
@mloskot
mloskot approved these changes Sep 4, 2019
Copy link
Member

mloskot left a comment

Looks good to me. Thank you for your work.

I will leave the compilation warnings issue, if any, for your discretion.

@lpranam lpranam force-pushed the lpranam:boundary_extension branch from aae0599 to 5af3633 Sep 4, 2019
@lpranam lpranam force-pushed the lpranam:boundary_extension branch from 5af3633 to c46f31e Sep 4, 2019
@lpranam lpranam force-pushed the lpranam:boundary_extension branch from c46f31e to c70c5ba Sep 4, 2019
@mloskot

This comment has been minimized.

Copy link
Member

mloskot commented Sep 5, 2019

@stefanseefeld Are you happy with Pranam's change addressing your #386 (comment) ?

@lpranam Is this ready to merge?

@lpranam

This comment has been minimized.

Copy link
Contributor Author

lpranam commented Sep 5, 2019

@lpranam Is this ready to merge?

@mloskot from my side it's ready

@mloskot mloskot merged commit 6a1c99a into boostorg:develop Sep 5, 2019
9 checks passed
9 checks passed
boostorg.gil Build #20190904.4 succeeded
Details
boostorg.gil (macos1013_xcode91_cmake) macos1013_xcode91_cmake succeeded
Details
boostorg.gil (ubuntu1604_gcc5_cxx11_cmake) ubuntu1604_gcc5_cxx11_cmake succeeded
Details
boostorg.gil (ubuntu1604_gcc8_cxx14_cmake) ubuntu1604_gcc8_cxx14_cmake succeeded
Details
boostorg.gil (win2012_vs2015_cmake) win2012_vs2015_cmake succeeded
Details
boostorg.gil (win2016_vs2017_cxx14_cmake) win2016_vs2017_cxx14_cmake succeeded
Details
boostorg.gil (win2016_vs2017_cxx17_cmake) win2016_vs2017_cxx17_cmake succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mloskot

This comment has been minimized.

Copy link
Member

mloskot commented Sep 5, 2019

Thanks!

@lpranam lpranam deleted the lpranam:boundary_extension branch Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.