Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented median_filter #393

Merged
merged 1 commit into from Oct 15, 2019
Merged

Conversation

@miralshah365
Copy link
Contributor

miralshah365 commented Sep 25, 2019

Description

implemented median_filter function

tests added for median_filter

This utility will provide a way to remove noise from the image by choosing a median value from a window which iterates over entire image.

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve
@miralshah365 miralshah365 added this to the Boost 1.72+ milestone Sep 25, 2019
@miralshah365 miralshah365 requested a review from mloskot Sep 25, 2019
@miralshah365 miralshah365 self-assigned this Sep 25, 2019
@miralshah365 miralshah365 force-pushed the miralshah365:median_filter branch from 092da74 to 5d6df23 Oct 7, 2019
@mloskot mloskot added this to In progress in [gsoc2019] Image Processing Algorithms via automation Oct 7, 2019
include/boost/gil/image_processing/filter.hpp Outdated Show resolved Hide resolved
@miralshah365 miralshah365 force-pushed the miralshah365:median_filter branch from 5d6df23 to f448f2c Oct 11, 2019
@miralshah365 miralshah365 requested a review from mloskot Oct 11, 2019
@miralshah365 miralshah365 force-pushed the miralshah365:median_filter branch from f448f2c to 0575fe4 Oct 13, 2019
@miralshah365 miralshah365 requested a review from mloskot Oct 13, 2019
Copy link
Member

mloskot left a comment

@miralshah365 Good work.

The only important comment I have is about the optimisation of std::vector use.
Once we resolve that one, your PR is ready to merge.

include/boost/gil/image_processing/filter.hpp Outdated Show resolved Hide resolved
include/boost/gil/image_processing/filter.hpp Outdated Show resolved Hide resolved
tests for median_filter added
@miralshah365 miralshah365 force-pushed the miralshah365:median_filter branch from 0575fe4 to f8aa340 Oct 13, 2019
Copy link
Member

mloskot left a comment

@miralshah365 Thank you for your prompt updates. It looks good. Feel free to merge as soon as all our CI-s pass.

@mloskot mloskot marked this pull request as ready for review Oct 13, 2019
@miralshah365 miralshah365 merged commit 8f1bd53 into boostorg:develop Oct 15, 2019
9 checks passed
9 checks passed
boostorg.gil Build #20191013.3 succeeded
Details
boostorg.gil (macos1013_xcode91_cmake) macos1013_xcode91_cmake succeeded
Details
boostorg.gil (ubuntu1604_gcc5_cxx11_cmake) ubuntu1604_gcc5_cxx11_cmake succeeded
Details
boostorg.gil (ubuntu1604_gcc8_cxx14_cmake) ubuntu1604_gcc8_cxx14_cmake succeeded
Details
boostorg.gil (win2012_vs2015_cmake) win2012_vs2015_cmake succeeded
Details
boostorg.gil (win2016_vs2017_cxx14_cmake) win2016_vs2017_cxx14_cmake succeeded
Details
boostorg.gil (win2016_vs2017_cxx17_cmake) win2016_vs2017_cxx17_cmake succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
[gsoc2019] Image Processing Algorithms automation moved this from In progress to Done Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.