Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove include/boost/gil/version.hpp file as unused #403

Merged
merged 1 commit into from Nov 9, 2019

Conversation

@mloskot
Copy link
Member

mloskot commented Nov 6, 2019

Description

Removing version.hpp added to GIL in dfc86f6 (Boost 1.68)

Motivation:

  • GIL is part of Boost collection, so Boost version is sufficient
  • GIL version makes little sense unless GIL becomes independent
  • Two distinct version numbers, Boost's and GIL's, are confusing.
  • Role of GIL's version number is not documented thus not entirely clear

References

The removal was discussed and agreed upon in this thread
https://lists.boost.org/boost-gil/2019/11/0346.php

Tasklist

  • Ensure all CI builds pass

/cc @stefanseefeld, @lpranam

Motivation:

  - GIL is part of Boost collection, so Boost version is sufficient
  - GIL version makes little sense unless GIL becomes independent
  - Two distinct version numbers, Boost's and GIL's, are confusing.
  - Role of GIL's version number is not documented thus not entirely clear

The removal was discussed and agreed upon in this thread
https://lists.boost.org/boost-gil/2019/11/0346.php
@mloskot mloskot added this to the Boost 1.72 milestone Nov 6, 2019
Copy link
Member

stefanseefeld left a comment

Thanks ! (I take it we are not referring to this version anywhere in our docs ?)

@mloskot

This comment has been minimized.

Copy link
Member Author

mloskot commented Nov 6, 2019

Yes, I think I checked all places, and final grep checks return nothing

$ find . -type f | grep -i BOOST_GIL_VERSION
$ find . -type f | grep -i BOOST_GIL_LIB_VERSION
@mloskot mloskot merged commit 84b1556 into boostorg:develop Nov 9, 2019
9 checks passed
9 checks passed
boostorg.gil Build #20191106.1 succeeded
Details
boostorg.gil (macos1013_xcode91_cmake) macos1013_xcode91_cmake succeeded
Details
boostorg.gil (ubuntu1604_gcc5_cxx11_cmake) ubuntu1604_gcc5_cxx11_cmake succeeded
Details
boostorg.gil (ubuntu1604_gcc8_cxx14_cmake) ubuntu1604_gcc8_cxx14_cmake succeeded
Details
boostorg.gil (win2012_vs2015_cmake) win2012_vs2015_cmake succeeded
Details
boostorg.gil (win2016_vs2017_cxx14_cmake) win2016_vs2017_cxx14_cmake succeeded
Details
boostorg.gil (win2016_vs2017_cxx17_cmake) win2016_vs2017_cxx17_cmake succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mloskot mloskot deleted the mloskot:ml/remove-version-hpp branch Nov 9, 2019
mloskot added a commit that referenced this pull request Nov 23, 2019
mloskot added a commit that referenced this pull request Nov 23, 2019
* develop:
  Update Boost 1.72.0 release notes with PR #403
  Mention C++11 in meta/libraries.json
  Add release notes in Markdown format (#404)
  Typo in README
  Remove include/boost/gil/version.hpp file as unused (#403)
  Add Markdown linting with Node package markdownlint
  doc/README.md: clarify steps building docs
  CONTRIBUTING.md: Remove logo as unnecessary
  README.md: Fix FreeNode link and hash escape
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.