New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing header #104

Merged
merged 1 commit into from Apr 3, 2018

Conversation

Projects
None yet
4 participants
@davydden
Contributor

davydden commented Mar 31, 2018

following https://svn.boost.org/trac10/ticket/13505#comment:4 I create a PR here

p.s. #101 is a better fix, but I would really like to have this fixed for 1.67.0 as this is a regression

@danieljames danieljames merged commit 85b3f97 into boostorg:develop Apr 3, 2018

danieljames added a commit that referenced this pull request Apr 3, 2018

@morinmorin

This comment has been minimized.

Member

morinmorin commented Apr 4, 2018

@danieljames
Thanks for merging!

@davydden
Could you make a comment in PR #101 that asks for updating the PR to delete the newly added line #include <boost/iterator.hpp>? Thanks in advance.

Regards,
Michel Morin

@DanielaE

This comment has been minimized.

Contributor

DanielaE commented Apr 4, 2018

Michel, I've rebased PR #101 accordingly.

Ciao
Dani

@morinmorin

This comment has been minimized.

Member

morinmorin commented Apr 4, 2018

Thanks for the rebase!
Hopefully, Daniel maybe merge the PR after the release of Boost 1.67.

@danieljames

This comment has been minimized.

Contributor

danieljames commented Apr 4, 2018

No promises, the most important thing to do is try to get existing changes on develop ready for release, and fix test failures where possible.

@morinmorin

This comment has been minimized.

Member

morinmorin commented Apr 4, 2018

Oh, I didn't notice that there are many commits on develop that are not merged to master yet. I understand that cleaning up these discrepancies and fixing test failures have first priority.

@davydden davydden referenced this pull request Apr 24, 2018

Merged

Add boost 1.67.0 #7889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment