New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference from argument_type #105

Merged
merged 1 commit into from Apr 13, 2018

Conversation

Projects
None yet
1 participant
@danieljames
Contributor

danieljames commented Mar 31, 2018

The reference was added in pull request #89. It causes a regression in transitive_closure_test compiled with gcc 4.4 in C++98 mode.

The error message from: https://www.boost.org/development/tests/develop/developer/output/teeks99-02-dg4-4-98-Docker-64on64-boost-bin-v2-libs-graph-test-transitive_closure_test-test-gcc-4-4~c++98-debug.html

In file included from /usr/include/c++/4.4/string:50,
                 from /usr/include/c++/4.4/bits/locale_classes.h:42,
                 from /usr/include/c++/4.4/bits/ios_base.h:43,
                 from /usr/include/c++/4.4/ios:43,
                 from /usr/include/c++/4.4/ostream:40,
                 from /usr/include/c++/4.4/iostream:40,
                 from ../libs/graph/test/transitive_closure_test.cpp:7:
/usr/include/c++/4.4/bits/stl_function.h: In instantiation of 'std::unary_negate<boost::detail::subscript_t<std::vector<long unsigned int, std::allocator<long unsigned int> >, long unsigned int, long unsigned int> >':
../boost/graph/transitive_closure.hpp:157:   instantiated from 'void boost::transitive_closure(const Graph&, GraphTC&, G_to_TC_VertexMap, VertexIndexMap) [with Graph = std::vector<std::vector<int, std::allocator<int> >, std::allocator<std::vector<int, std::allocator<int> > > >, GraphTC = std::vector<std::vector<int, std::allocator<int> >, std::allocator<std::vector<int, std::allocator<int> > > >, G_to_TC_VertexMap = boost::iterator_property_map<__gnu_cxx::__normal_iterator<int*, std::vector<int, std::allocator<int> > >, boost::typed_identity_property_map<long unsigned int>, int, int&>, VertexIndexMap = boost::typed_identity_property_map<long unsigned int>]'
../boost/graph/transitive_closure.hpp:285:   instantiated from 'void boost::detail::transitive_closure_dispatch(const Graph&, GraphTC&, G_to_TC_VertexMap, VertexIndexMap) [with Graph = std::vector<std::vector<int, std::allocator<int> >, std::allocator<std::vector<int, std::allocator<int> > > >, GraphTC = std::vector<std::vector<int, std::allocator<int> >, std::allocator<std::vector<int, std::allocator<int> > > >, G_to_TC_VertexMap = boost::param_not_found, VertexIndexMap = boost::typed_identity_property_map<long unsigned int>]'
../boost/graph/transitive_closure.hpp:300:   instantiated from 'void boost::transitive_closure(const Graph&, GraphTC&, const boost::bgl_named_params<P, T, R>&) [with Graph = std::vector<std::vector<int, std::allocator<int> >, std::allocator<std::vector<int, std::allocator<int> > > >, GraphTC = std::vector<std::vector<int, std::allocator<int> >, std::allocator<std::vector<int, std::allocator<int> > > >, P = boost::typed_identity_property_map<long unsigned int>, T = boost::vertex_index_t, R = boost::no_property]'
../libs/graph/test/transitive_closure_test.cpp:120:   instantiated from here
/usr/include/c++/4.4/bits/stl_function.h:357: error: forming reference to reference type 'long unsigned int&'
Remove reference from argument_type
The reference was added in pull request #89. It causes a regression of gcc 4.4
in C++98 mode.

@danieljames danieljames merged commit 98899a6 into boostorg:develop Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment