Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of deprecated headers boost/bind.hpp and boost/detail/iterator.hpp #218

Merged
merged 2 commits into from Nov 2, 2020

Conversation

Lastique
Copy link
Member

These headers emit deprecation warnings and are subject to future removal.

Also, added a few missing includes.

The header was deprecated in favor of <iterator>. It generates compiler
warnings and will be removed in a future release.
boost/bind.hpp generates compiler warnings about deprecation of placeholders
in the global namespace. Updated to include boost/bind/bind.hpp and
using namespace boost::placeholders;

Also added a few missing includes.
@sdebionne
Copy link

@Lastique Thanks for fixing these annoying warnings, I see that the same modifications in property_map were merged OK. Looking at the failing CI jobs, it looks like it is related to XCode, a typo in filesystem (st_mtim instead of st_mtime). That might have been fixed, any chance that you could trigger the CI again?

@Lastique Lastique closed this Sep 16, 2020
@Lastique Lastique reopened this Sep 16, 2020
@sdebionne
Copy link

sdebionne commented Sep 16, 2020

@jzmaddock Can this please be merged ?

@sdebionne
Copy link

@jzmaddock @glenfe Could this be merged for 1.75, please?

@jzmaddock jzmaddock merged commit e4e1215 into boostorg:develop Nov 2, 2020
@Lastique Lastique deleted the fix_deprecated_headers branch November 2, 2020 15:50
@maxGimeno maxGimeno mentioned this pull request Apr 6, 2021
@fkonvick
Copy link

@jzmaddock This still does not seem to be in 1.76 - as of rc1 boost/graph/adjacency_iterator.hpp still #includes boost/detail/iterator.hpp

@hebaishi
Copy link

Just checked the boost 1.76.0 release and this isn't in there. 😢

@jzmaddock
Copy link
Contributor

Sorry guys, looks like I dropped the ball on that. Let me see what state CI is in, and then try and do a merge to master...

@fkonvick
Copy link

No problem, better safe than sorry. I'm fine waiting for the next release :) Thanks.

@jzmaddock
Copy link
Contributor

Now merged to master.

@jwakely
Copy link
Contributor

jwakely commented May 7, 2021

Why does Boost still use such an error-prone branch workflow that requires manually merging individual fixes? 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants