New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix usage of deprecated headers boost/bind.hpp and boost/detail/iterator.hpp #218
Conversation
The header was deprecated in favor of <iterator>. It generates compiler warnings and will be removed in a future release.
boost/bind.hpp generates compiler warnings about deprecation of placeholders in the global namespace. Updated to include boost/bind/bind.hpp and using namespace boost::placeholders; Also added a few missing includes.
|
@Lastique Thanks for fixing these annoying warnings, I see that the same modifications in property_map were merged OK. Looking at the failing CI jobs, it looks like it is related to XCode, a typo in filesystem ( |
|
@jzmaddock Can this please be merged ? |
|
@jzmaddock @glenfe Could this be merged for 1.75, please? |
|
@jzmaddock This still does not seem to be in 1.76 - as of rc1 boost/graph/adjacency_iterator.hpp still #includes boost/detail/iterator.hpp |
|
Just checked the boost 1.76.0 release and this isn't in there. 😢 |
|
Sorry guys, looks like I dropped the ball on that. Let me see what state CI is in, and then try and do a merge to master... |
|
No problem, better safe than sorry. I'm fine waiting for the next release :) Thanks. |
|
Now merged to master. |
|
Why does Boost still use such an error-prone branch workflow that requires manually merging individual fixes? 😢 |
These headers emit deprecation warnings and are subject to future removal.
Also, added a few missing includes.