New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler error with release builds on VS2015 #84

Merged
merged 1 commit into from May 26, 2017

Conversation

Projects
None yet
3 participants
@nre-ableton
Contributor

nre-ableton commented Dec 22, 2016

When using MSVC compiler optimization, using param_not_found() causes compiler error C4172: returning address of local variable or temporary

Fix compiler error with release builds on VS2015
When using MSVC compiler optimization, using param_not_found() causes
compiler error C4172: returning address of local variable or temporary

@Belcourt Belcourt merged commit eda383e into boostorg:develop May 26, 2017

@nre-ableton nre-ableton deleted the nre-ableton:nre/develop/vs2015-release-compiler-error branch May 29, 2017

@jcageman

This comment has been minimized.

jcageman commented Dec 8, 2017

I got the exact compile error fixed here using 1.65.1. Why is this not in 1.65.1?

@nre-ableton

This comment has been minimized.

Contributor

nre-ableton commented Dec 8, 2017

@jcageman According to the changelog, 1.65.1 does not contain an updated version of the graph module. Hopefully it will be shipped in the next release.

@jcageman

This comment has been minimized.

jcageman commented Dec 8, 2017

Thanks for the quick reply. This is necessary to get boost compiling with VS2015/2017 so i would argue its a pretty important fix (maybe just on its own without other graph changes). Could you at least ensure it gets the right priority for next release? For now i will fix this in our local version.

@nre-ableton

This comment has been minimized.

Contributor

nre-ableton commented Dec 8, 2017

@jcageman Sorry, I'm not affiliated with the Boost project, I just made the patch. 😉

@jcageman

This comment has been minimized.

jcageman commented Dec 8, 2017

Oke, thanks for the patch at least!

masterleinad added a commit to masterleinad/dealii that referenced this pull request Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment