Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One test from boost libraries failed to run after boost submodule throw_exception updated from 50c34d to 514355 #28

Closed
spacelg opened this issue Jun 18, 2019 · 3 comments

Comments

@spacelg
Copy link

commented Jun 18, 2019

Environment:
VS 2017 + Windows Server 2016

One test from boost libraries failed to run after boost submodule throw_exception updated from 50c34d to 514355 boost/throw_exception@a40a714. Could you please take a look?

Reproduce steps:.

  1. git clone -c core.autocrlf=true --recursive ​https://github.com/boostorg/boost.git D:\Boost\src
  2. open a VS 2017 x64 command prompt and browse to D:\Boost\src
  3. .\bootstrap
  4. .\b2 headers variant=release --build-dir=..\out\x64rel address-model=64
  5. .\b2 variant=release --build-dir=..\out\x64rel address-model=64
  6. .\b2 -j4 variant=release --build-dir=..\out\x64rel libs\lexical_cast\test

log_x64_test_56.log

ErrorMessage:
testing.capture-output ..\out\x64rel\boost\bin.v2\libs\lexical_cast\test\lexical_cast_no_exceptions_test.test\msvc-14.1\release\link-static\threading-multi\lexical_cast_no_exceptions_test.run
====== BEGIN OUTPUT ======
Running 1 test case...
unknown location(0): fatal error: in "lexical_cast. Testing with BOOST_NO_EXCEPTIONS/test_exceptions_off": breakpoint encountered

*** 1 failure is detected in the test module "Master Test Suite"

EXIT STATUS: 201
====== END OUTPUT ======

set status=0
if %status% NEQ 0 (
    echo Skipping test execution due to testing.execute=off
    exit 0
)
 "..\out\x64rel\boost\bin.v2\libs\lexical_cast\test\lexical_cast_no_exceptions_test.test\msvc-14.1\release\link-static\threading-multi\lexical_cast_no_exceptions_test.exe"   > "..\out\x64rel\boost\bin.v2\libs\lexical_cast\test\lexical_cast_no_exceptions_test.test\msvc-14.1\release\link-static\threading-multi\lexical_cast_no_exceptions_test.output" 2>&1 
set status=%ERRORLEVEL%
echo. >> "..\out\x64rel\boost\bin.v2\libs\lexical_cast\test\lexical_cast_no_exceptions_test.test\msvc-14.1\release\link-static\threading-multi\lexical_cast_no_exceptions_test.output"
echo EXIT STATUS: %status% >> "..\out\x64rel\boost\bin.v2\libs\lexical_cast\test\lexical_cast_no_exceptions_test.test\msvc-14.1\release\link-static\threading-multi\lexical_cast_no_exceptions_test.output"
if %status% EQU 0 (
    copy "..\out\x64rel\boost\bin.v2\libs\lexical_cast\test\lexical_cast_no_exceptions_test.test\msvc-14.1\release\link-static\threading-multi\lexical_cast_no_exceptions_test.output" "..\out\x64rel\boost\bin.v2\libs\lexical_cast\test\lexical_cast_no_exceptions_test.test\msvc-14.1\release\link-static\threading-multi\lexical_cast_no_exceptions_test.run"
)
set verbose=0
if %status% NEQ 0 (
    set verbose=1
)
if %verbose% EQU 1 (
    echo ====== BEGIN OUTPUT ======
    type "..\out\x64rel\boost\bin.v2\libs\lexical_cast\test\lexical_cast_no_exceptions_test.test\msvc-14.1\release\link-static\threading-multi\lexical_cast_no_exceptions_test.output"
    echo ====== END OUTPUT ======
)
exit %status%

...failed testing.capture-output

@pdimov

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

Thanks for the report. I'll transfer this issue to lexical_cast, because the test needs to be updated.

@pdimov pdimov transferred this issue from boostorg/throw_exception Jun 18, 2019

@pdimov

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

boost::throw_exception now enforces "must not return" by being declared with BOOST_NORETURN, so the test must be updated to not rely on returning from it. boostorg/throw_exception@1e50792

apolukhin added a commit that referenced this issue Jun 21, 2019
@apolukhin

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

Additional fixes were applied in 3786d41

Will merge to master soon.

@apolukhin apolukhin closed this Jun 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.