Skip to content

Fix order of environment variables when getting system default locale #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 7, 2023

Conversation

Flamefire
Copy link
Collaborator

@Flamefire Flamefire commented Jan 1, 2023

As per POSIX, see chapter 8.2, and linux man-pages, see man locale.7 the order should be

  • LC_ALL
  • LC_CTYPE
  • LANG

This PR does this using the changes from #22

@Flamefire Flamefire force-pushed the system_locale branch 5 times, most recently from 8e899e2 to 8b6ae16 Compare January 3, 2023 21:23
Put `GetLocaleInfoA` into a function returning a bool to make it easier
to understand.
@codecov
Copy link

codecov bot commented Jan 7, 2023

Codecov Report

Merging #144 (b593463) into develop (343306a) will increase coverage by 0.10%.
The diff coverage is 91.11%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #144      +/-   ##
===========================================
+ Coverage    88.04%   88.15%   +0.10%     
===========================================
  Files          104      106       +2     
  Lines         9181     9207      +26     
===========================================
+ Hits          8083     8116      +33     
+ Misses        1098     1091       -7     
Impacted Files Coverage Δ
include/boost/locale/format.hpp 94.32% <ø> (ø)
include/boost/locale/util.hpp 14.28% <ø> (ø)
src/boost/locale/shared/formatting.cpp 90.76% <0.00%> (ø)
test/test_ios_prop.cpp 100.00% <ø> (ø)
include/boost/locale/message.hpp 92.71% <50.00%> (ø)
src/boost/locale/util/default_locale.cpp 92.59% <91.66%> (+24.73%) ⬆️
include/boost/locale/date_time.hpp 93.98% <100.00%> (ø)
test/test_helpers.cpp 100.00% <100.00%> (ø)
test/test_util.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 343306a...b593463. Read the comment docs.

@Flamefire Flamefire merged commit 9c010b9 into boostorg:develop Jan 7, 2023
@Flamefire Flamefire deleted the system_locale branch January 7, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants