Skip to content

Better locale name support #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 1, 2023
Merged

Better locale name support #148

merged 9 commits into from
Mar 1, 2023

Conversation

Flamefire
Copy link
Collaborator

Fixes #58

@Flamefire Flamefire force-pushed the better-locale-name-support branch 5 times, most recently from 70db92c to b14862f Compare February 28, 2023 16:27
Flamefire and others added 4 commits February 28, 2023 18:06
@Flamefire
CI: Run default tests (ICU&IConv) & show_config first
0cc8934
@mattjgalloway @Flamefire
Add support for en_001 and en_150 locales
a83a589 
This addresses boostorg#58, by allowing 0-9 in the range of characters for the country of a locale.
@Flamefire
Use is_numeric_ascii
dd7de6f
@Flamefire
Allow only M49 format in addition to ISO 3166 format for country in l…
17c30c5 
…ocale ID

Reject country strings which are not ASCII letters and not in M.49 format (exactly 3 digits).
Also add tests
@Flamefire Flamefire force-pushed the better-locale-name-support branch from b14862f to 330304f Compare February 28, 2023 17:28
@Flamefire Flamefire enabled auto-merge February 28, 2023 17:28
@Flamefire Flamefire disabled auto-merge February 28, 2023 21:13
@Flamefire Flamefire force-pushed the better-locale-name-support branch from 330304f to 0a66153 Compare March 1, 2023 16:10
@Flamefire Flamefire enabled auto-merge March 1, 2023 17:00
@Flamefire Flamefire merged commit 7fe8ec0 into boostorg:develop Mar 1, 2023
@Flamefire Flamefire deleted the better-locale-name-support branch March 2, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not supporting en_001, en_150 or en_US_POSIX locale
2 participants
@Flamefire @mattjgalloway