Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid iterator increment/decrement in the last iteration of adaptive_sort_combine_blocks #26

Closed
igaztanaga opened this issue Apr 24, 2019 · 0 comments

Comments

@igaztanaga
Copy link
Member

commented Apr 24, 2019

In a left/right merge, combined_first is always increased/decreased the regular size:

combined_first += l_reg_combined

combined_first -= l_reg_combined

This is invalid when the last iteration is not regular. The problem shows up when using stable_vector::iterators, which crash when incremented out of bounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.