Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boost::nowide::quoted to read/write paths from/to streams. #170

Merged
merged 2 commits into from
Mar 4, 2023

Conversation

Flamefire
Copy link
Collaborator

Closes #136

@SandroWissmann This will allow you to do e.g. os << boost::nowide::quoted(path)

I hope that meets your requirements.

@Flamefire Flamefire force-pushed the add-quoted branch 3 times, most recently from 9bfcf89 to 36b469a Compare March 3, 2023 13:50
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #170 (990710a) into develop (cdcd704) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #170   +/-   ##
========================================
  Coverage    99.46%   99.47%           
========================================
  Files           33       34    +1     
  Lines         3387     3447   +60     
========================================
+ Hits          3369     3429   +60     
  Misses          18       18           
Impacted Files Coverage Δ
include/boost/nowide/quoted.hpp 100.00% <100.00%> (ø)
include/boost/nowide/utf/convert.hpp 100.00% <100.00%> (ø)
test/test_fs.cpp 100.00% <100.00%> (ø)
test/test_traits.cpp 100.00% <0.00%> (ø)
test/test_convert.cpp 100.00% <0.00%> (ø)

`std::quoted` requires C++14 while std::filesystem::path requires C++17 so to test those with coverage we need to include the newer standards.
@Flamefire Flamefire merged commit cd3b01d into boostorg:develop Mar 4, 2023
@Flamefire Flamefire deleted the add-quoted branch March 4, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boost::nowide::cout cannot output std::filesystem::path correctly
1 participant