Add boost::nowide::quoted to read/write paths from/to streams. - #170
Merged
Conversation
Flamefire
force-pushed
the
add-quoted
branch
3 times, most recently
from
March 3, 2023 13:50
9bfcf89 to
36b469a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #170 +/- ##
========================================
Coverage 99.46% 99.47%
========================================
Files 33 34 +1
Lines 3387 3447 +60
========================================
+ Hits 3369 3429 +60
Misses 18 18
|
`std::quoted` requires C++14 while std::filesystem::path requires C++17 so to test those with coverage we need to include the newer standards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #136
@SandroWissmann This will allow you to do e.g.
os << boost::nowide::quoted(path)I hope that meets your requirements.