New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost::mutex use to avoid a dependency on Boost.Thread #23

Merged
merged 1 commit into from Aug 29, 2018

Conversation

Projects
None yet
2 participants
@pdimov
Copy link
Contributor

pdimov commented Aug 28, 2018

Pool is at level 15 in the dependency report at the moment, solely because of Boost.Thread.

This also fixes the longstanding https://svn.boost.org/trac10/ticket/7085, I believe.

@eldiener

This comment has been minimized.

Copy link
Contributor

eldiener commented Aug 28, 2018

There is a test_threading.cpp which uses Boost.Thread to run threads in which Boost.Pool is being used.

@pdimov

This comment has been minimized.

Copy link
Contributor

pdimov commented Aug 28, 2018

Correct, you still need Boost.Thread to run the tests, but most people don't do that.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 28, 2018

Codecov Report

Merging #23 into develop will increase coverage by 0.98%.
The diff coverage is 54.54%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #23      +/-   ##
===========================================
+ Coverage    70.41%   71.39%   +0.98%     
===========================================
  Files            8        8              
  Lines          436      444       +8     
  Branches       136      132       -4     
===========================================
+ Hits           307      317      +10     
- Misses          28       30       +2     
+ Partials       101       97       -4
Impacted Files Coverage Δ
include/boost/pool/detail/mutex.hpp 54.54% <54.54%> (-45.46%) ⬇️
include/boost/pool/singleton_pool.hpp 50% <0%> (+15.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9daab9f...9def9a5. Read the comment docs.

@eldiener eldiener merged commit 19d5c61 into develop Aug 29, 2018

3 of 4 checks passed

codecov/patch 54.54% of diff hit (target 70.41%)
Details
codecov/project 71.39% (+0.98%) compared to 9daab9f
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeking3 jeking3 deleted the pr/no-boost-thread branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment