Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression reported in #23 #24

Merged
merged 5 commits into from Jul 5, 2019

Conversation

@pdimov
Copy link
Contributor

commented Jul 5, 2019

This fixes the regression reported in issue #23.

Whether the same change needs to be applied to the other containers is an open question.

This fixes #23

@jeking3

This comment has been minimized.

Copy link
Collaborator

commented Jul 5, 2019

I assume this is something we want to pull into 1.71?

@jeking3

This comment has been minimized.

Copy link
Collaborator

commented Jul 5, 2019

I should update the CI to the latest boot-ci spec which does a bit less work than the one used here right now.

@pdimov

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

Yes, I think that we want this fix in 1.71 (unless further develop/master testing indicates a problem with the fix itself).

@jeking3

This comment has been minimized.

Copy link
Collaborator

commented Jul 5, 2019

If you think this deserves a release note entry, let me know what you would like it to say and I will submit a PR for it.

@jeking3 jeking3 merged commit ea3fa75 into develop Jul 5, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jeking3 jeking3 deleted the feature/issue-23 branch Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.