Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added constexpr support to min/max functions of random number generators. Fixes #12251 #24

Open
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
2 participants
@gblanco92
Copy link

gblanco92 commented Jun 3, 2016

@mclow

This comment has been minimized.

Copy link
Contributor

mclow commented Jun 3, 2016

The code changes look good, but there are no tests!

@gblanco92

This comment has been minimized.

Copy link
Author

gblanco92 commented Jun 7, 2016

I will add tests for this!

@mclow

This comment has been minimized.

Copy link
Contributor

mclow commented May 4, 2017

Ping?

danieljames added a commit to danieljames/graph that referenced this pull request Apr 13, 2018

Use std::mt19937 where available
In C++17 mode, libc++'s `std::shuffle` isn't compatible with Boost's random
generators because the `min` and `max` functions aren't `constexpr`, so use
`std::mt19937` instead. This might not be required if boostorg/random#24 is
accepted.

danieljames added a commit to danieljames/graph that referenced this pull request Apr 13, 2018

Use std::mt19937 where available
In C++17 mode, libc++'s `std::shuffle` isn't compatible with Boost's random
generators because the `min` and `max` functions aren't `constexpr`, so use
`std::mt19937` instead. This might not be required if boostorg/random#24 is
accepted.

@rstub rstub referenced this pull request Jan 10, 2019

Closed

remove random header #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.