New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI framework and fix undefined behavior #19

Merged
merged 1 commit into from Jun 14, 2018

Conversation

Projects
None yet
3 participants
@jeking3
Collaborator

jeking3 commented Jun 13, 2018

  • travis with valgrind, cppcheck, ubsan, codecov, covscan (future)
  • appveyor with MSVC 2010 through 2017, cygwin 32/64, mingw 32/64
  • README, LICENSE, etc.

Implementing the CI framework exposed some undefined behavior in release mode builds which was also resolved.

This fixes #18

@jeking3 jeking3 self-assigned this Jun 13, 2018

@jeking3 jeking3 requested review from swatanabe and mclow Jun 13, 2018

@codecov

This comment has been minimized.

codecov bot commented Jun 13, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (develop@ee177e6). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #19   +/-   ##
==========================================
  Coverage           ?   67.52%           
==========================================
  Files              ?        1           
  Lines              ?      271           
  Branches           ?       90           
==========================================
  Hits               ?      183           
  Misses             ?        3           
  Partials           ?       85
Impacted Files Coverage Δ
include/boost/rational.hpp 67.52% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee177e6...76989ff. Read the comment docs.

@mclow

This comment has been minimized.

Contributor

mclow commented Jun 13, 2018

I like the fix. LGTM.

(Also feeling good, because I nailed the cause: "undefined behavior", and bad because I should have identified the failing bit from the description)

Add CI framework
  - travis with valgrind, cppcheck, ubsan, codecov, covscan (future)
  - appveyor with MSVC 2010 through 2017, cygwin 32/64, mingw 32/64
  - README, LICENSE, etc.

@jeking3 jeking3 force-pushed the jeking3:ci branch from 64aff26 to 76989ff Jun 14, 2018

@jeking3 jeking3 merged commit 63f7de8 into boostorg:develop Jun 14, 2018

4 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeking3 jeking3 deleted the jeking3:ci branch Jun 14, 2018

@jeking3

This comment has been minimized.

Collaborator

jeking3 commented Jun 14, 2018

It looks like the implementation of operator /= has the same undefined behavior, potentially, but I'm not sure if the code above that would ever allow it to get that value.

@swatanabe

This comment has been minimized.

Contributor

swatanabe commented Jun 14, 2018

@jeking3 jeking3 added this to the v1.68.0 milestone Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment