Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support: Endian problems #349

Merged
merged 4 commits into from Mar 7, 2019

Conversation

Projects
None yet
2 participants
@Kojoley
Copy link
Collaborator

commented Jan 4, 2018

  • Fixed macro redefinition:
    • BOOST_MINIMAL_INTEGER_COVER_OPERATORS
    • BOOST_NO_IO_COVER_OPERATORS
    • BOOST_SPIRIT_ENDIAN_NO_CTORS
    • BOOST_SPIRIT_ENDIAN_DEFAULT_CONSTRUCT
  • Undef internal macros.
  • Fixed-width integer detection.

Closes #348

@Kojoley

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 4, 2018

Also I am not sure why Spirit still does not use Boost.Endian (but I dislike that its io operators cannot be turned off, Spirit one does not have them).

@Kojoley Kojoley force-pushed the Kojoley:support-endian-problems branch from 692acb8 to d80aad6 Jan 4, 2018

@djowel

This comment has been minimized.

Copy link
Member

commented Jan 4, 2018

We should probably use Boost.Endian if we can. Does the io operators affect Spirit use?

@Kojoley

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 4, 2018

It only includes iosfwd so it should not hurt users.

@Kojoley

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 7, 2018

Boost.Endian is implemented with bit shifts on a passed type (only recently it started to cast signed to unsigned before shifting :O). Because of that float types are not supported and we cannot simply switch Karma and Qi to it.

@Kojoley Kojoley force-pushed the Kojoley:support-endian-problems branch 4 times, most recently from 0656dcb to 9d9b398 Mar 7, 2019

@Kojoley Kojoley force-pushed the Kojoley:support-endian-problems branch from 9d9b398 to 9e64877 Mar 7, 2019

@Kojoley Kojoley merged commit 38ec0cc into boostorg:develop Mar 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Kojoley Kojoley deleted the Kojoley:support-endian-problems branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.