New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop own fp routines in favor of `boost::math` #392

Merged
merged 1 commit into from Jul 29, 2018

Conversation

Projects
None yet
3 participants
@Kojoley
Collaborator

Kojoley commented Jul 27, 2018

Remove own fp routines as Boost 1.40 released ~9 years ago.
The boost::math::changesign usage fixes trac 13531.

Drop own fp routines in favor of `boost::math`
Remove own fp routines as Boost 1.40 released ~9 years ago.
The `boost::math::changesign` usage fixes trac 13531.
@Kojoley

This comment has been minimized.

Collaborator

Kojoley commented Jul 27, 2018

Actually I do not know what is the purpose of using math::changesign. Simple -n makes this work perfectly (it correctly changes sign of NaN and Inf values) and compiles into a faster machine code (especially on older compilers and any msvc) https://godbolt.org/g/aVC152

@djowel

This comment has been minimized.

Member

djowel commented Jul 28, 2018

👍 I am for this PR. And yes, -n should be good, even for generic code.

@hkaiser

LGTM, thanks!

@hkaiser

This comment has been minimized.

Collaborator

hkaiser commented Jul 28, 2018

Actually I do not know what is the purpose of using math::changesign.

IIRC, this was an optimization that was much faster for double/float than -n.

@Kojoley Kojoley merged commit 652943c into boostorg:develop Jul 29, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Kojoley Kojoley deleted the Kojoley:use-boost-math-changesign branch Jul 29, 2018

@Kojoley Kojoley added this to the 1.69.0 milestone Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment