Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qi: rule: Added asserts for mismatching skipper types #427

Merged
merged 1 commit into from Dec 18, 2018

Conversation

Projects
None yet
2 participants
@Kojoley
Copy link
Collaborator

commented Dec 17, 2018

It looks like mismatching skipper types and parse/phrase_parse calls are
quite popular mistakes, and the actual problem is not clear for users despite
that there is a comment near the call that will fail and the hint should be
found by following to the file and line that compiler reports the error on.

Closes #426.

@Kojoley Kojoley force-pushed the Kojoley:qi-rule-skipper-asserts branch 2 times, most recently from 3993749 to 071cff1 Dec 17, 2018

Qi: rule: Added asserts for mismatching skipper types
It looks like mismatching skipper types and `parse`/`phrase_parse` calls are
quite popular mistakes, and the actual problem is not clear for users despite
that there is a comment near the call that will fail and the hint should be
found by following to the file and line that compiler reports the error on.

@Kojoley Kojoley force-pushed the Kojoley:qi-rule-skipper-asserts branch from 071cff1 to 0efdabd Dec 18, 2018

@Kojoley Kojoley merged commit e14eaa3 into boostorg:develop Dec 18, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Kojoley Kojoley deleted the Kojoley:qi-rule-skipper-asserts branch Dec 18, 2018

@mwpowellhtx

This comment has been minimized.

Copy link

commented Dec 18, 2018

I'm not sure what you mean:

... mismatching skipper types ...

That's not what's going on at all. I tried furnishing a skipper instance during my troubleshooting of the issue, yes; but that is by no means the root cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.