Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract_int: Custom integers support #429

Merged
merged 2 commits into from Jan 13, 2019

Conversation

Projects
None yet
1 participant
@Kojoley
Copy link
Collaborator

commented Dec 26, 2018

It will allow to test extract_int properly.

Changed default check_overflow trait implementation to be is_bounded
as it also covers float types and user data types.

Replacing boost::integer_traits with std::numeric_limits will not hurt
performance because even MSVC 9/GCC 4.1/Clang 3.0 folds min/max calls
to a constant at compile time and since C++11 they are even constexpr.

@Kojoley Kojoley force-pushed the Kojoley:extract_int-custom-ints-support branch 4 times, most recently from 7cf48e0 to 8c9f82a Dec 26, 2018

@Kojoley Kojoley force-pushed the Kojoley:extract_int-custom-ints-support branch from 8c9f82a to 9ae229d Jan 12, 2019

Kojoley added some commits Dec 24, 2018

Unbounded types can't be checked for overflow
Changed default `check_overflow` trait implementation to be `is_bounded`
as it also covers float types and user data types.
extract_int: Custom integers support
It will allow to test `extract_int` properly.

Replacing `boost::integer_traits` with `std::numeric_limits` will not hurt
performance because even MSVC 9/GCC 4.1/Clang 3.0 folds `min`/`max` calls
to a constant at compile time and since C++11 they are even constexpr.

@Kojoley Kojoley force-pushed the Kojoley:extract_int-custom-ints-support branch from 9ae229d to 65157ba Jan 12, 2019

@Kojoley Kojoley merged commit 2859693 into boostorg:develop Jan 13, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Kojoley Kojoley deleted the Kojoley:extract_int-custom-ints-support branch Jan 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.