Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X3: Perform attribute transformation before calling parse_rule #456

Conversation

Projects
None yet
1 participant
@Kojoley
Copy link
Collaborator

commented Feb 8, 2019

This will deal with linking problems when rule attribute type is not the same
as the actual attribute type. It will not harm anyone as the transformation
after parse_rule will just pass-through the attribute because it will be the
same there. It will also do not alter rule_definition parsing so other usages
are still valid.

Refs #454, supersedes #347.

X3: Perform attribute transformation before calling parse_rule
This will deal with linking problems when rule attribute type is not the same
as the actual attribute type. It will not harm anyone as the transformation
after parse_rule will just pass-through the attribute because it will be the
same there. It will also do not alter rule_definition parsing so other usages
are still valid.

@Kojoley Kojoley merged commit b5f1552 into boostorg:develop Feb 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Kojoley Kojoley deleted the Kojoley:x3-perform-transformation-before-parse_rule branch Feb 8, 2019

@Kojoley Kojoley referenced this pull request Feb 8, 2019

Closed

Boost spirit instantiate #347

Kojoley added a commit to Kojoley/spirit that referenced this pull request Feb 8, 2019

X3: parse_rule attribute must always be of rule::attribute_type&
After boostorg#456 `parse_rule` is always called with value of `rule::attribute_type&`
type. By removing attribute type deduction we also will turn any possible bug
in `transform_attribute` from a linkage to compile error.

Fixes boostorg#454

Kojoley added a commit that referenced this pull request Feb 9, 2019

X3: parse_rule attribute must always be of rule::attribute_type&
After #456 `parse_rule` is always called with value of `rule::attribute_type&`
type. By removing attribute type deduction we also will turn any possible bug
in `transform_attribute` from a linkage to compile error.

Fixes #454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.